content/renderer/media/media_recorder_handler.h - Issue 2444153002: MediaRecorder: bugfix start() means buffer-forever

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_recorder_handler.h

Issue 2444153002: MediaRecorder: bugfix start() means buffer-forever (Closed)

Patch Set: removed WebMediaRecorderHandler::start() Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/media_recorder_handler.h

diff --git a/content/renderer/media/media_recorder_handler.h b/content/renderer/media/media_recorder_handler.h

index d7d3d03ba634821204ca61e00f7a883ad6e3fab0..6b6265f9eb52b7bb288178b9be5a6a94ce22a8b2 100644

--- a/content/renderer/media/media_recorder_handler.h

+++ b/content/renderer/media/media_recorder_handler.h

@@ -57,7 +57,6 @@ class CONTENT_EXPORT MediaRecorderHandler final

const blink::WebString& codecs,

int32_t audio_bits_per_second,

int32_t video_bits_per_second) override;

- bool start() override;

bool start(int timeslice) override;

void stop() override;

void pause() override;