Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: content/renderer/media/media_recorder_handler.h

Issue 2444153002: MediaRecorder: bugfix start() means buffer-forever (Closed)
Patch Set: s/start(1)/start(0)/ Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/media/media_recorder_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_MEDIA_RECORDER_HANDLER_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_MEDIA_RECORDER_HANDLER_H_
6 #define CONTENT_RENDERER_MEDIA_MEDIA_RECORDER_HANDLER_H_ 6 #define CONTENT_RENDERER_MEDIA_MEDIA_RECORDER_HANDLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 50
51 // blink::WebMediaRecorderHandler. 51 // blink::WebMediaRecorderHandler.
52 bool canSupportMimeType(const blink::WebString& web_type, 52 bool canSupportMimeType(const blink::WebString& web_type,
53 const blink::WebString& web_codecs) override; 53 const blink::WebString& web_codecs) override;
54 bool initialize(blink::WebMediaRecorderHandlerClient* client, 54 bool initialize(blink::WebMediaRecorderHandlerClient* client,
55 const blink::WebMediaStream& media_stream, 55 const blink::WebMediaStream& media_stream,
56 const blink::WebString& type, 56 const blink::WebString& type,
57 const blink::WebString& codecs, 57 const blink::WebString& codecs,
58 int32_t audio_bits_per_second, 58 int32_t audio_bits_per_second,
59 int32_t video_bits_per_second) override; 59 int32_t video_bits_per_second) override;
60 bool start() override;
61 bool start(int timeslice) override; 60 bool start(int timeslice) override;
62 void stop() override; 61 void stop() override;
63 void pause() override; 62 void pause() override;
64 void resume() override; 63 void resume() override;
65 64
66 private: 65 private:
67 friend class MediaRecorderHandlerTest; 66 friend class MediaRecorderHandlerTest;
68 67
69 void OnEncodedVideo(const scoped_refptr<media::VideoFrame>& video_frame, 68 void OnEncodedVideo(const scoped_refptr<media::VideoFrame>& video_frame,
70 std::unique_ptr<std::string> encoded_data, 69 std::unique_ptr<std::string> encoded_data,
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 // Worker class doing the actual Webm Muxing work. 108 // Worker class doing the actual Webm Muxing work.
110 std::unique_ptr<media::WebmMuxer> webm_muxer_; 109 std::unique_ptr<media::WebmMuxer> webm_muxer_;
111 110
112 base::WeakPtrFactory<MediaRecorderHandler> weak_factory_; 111 base::WeakPtrFactory<MediaRecorderHandler> weak_factory_;
113 112
114 DISALLOW_COPY_AND_ASSIGN(MediaRecorderHandler); 113 DISALLOW_COPY_AND_ASSIGN(MediaRecorderHandler);
115 }; 114 };
116 115
117 } // namespace content 116 } // namespace content
118 #endif // CONTENT_RENDERER_MEDIA_MEDIA_RECORDER_HANDLER_H_ 117 #endif // CONTENT_RENDERER_MEDIA_MEDIA_RECORDER_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/media/media_recorder_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698