Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc

Issue 2444143002: Add process lifetime annotations to stack samples. (Closed)
Patch Set: abandon generator for on-the-fly Profiles creation Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc
diff --git a/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc b/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc
index 22265a6182249befd8498621825a99c7f69d02d1..8aa545574f74e6cd1f10f7eb348eb7dfdbcd9495 100644
--- a/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc
+++ b/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc
@@ -224,11 +224,11 @@ TEST_F(CallStackProfileStructTraitsTest, Profile) {
Module(0x4100, "b", base::FilePath()),
},
{
- {
- Frame(0x4010, 0),
- Frame(0x4110, 1),
- Frame(0x4110, Frame::kUnknownModuleIndex),
- }
+ Sample({
+ Frame(0x4010, 0),
+ Frame(0x4110, 1),
+ Frame(0x4110, Frame::kUnknownModuleIndex),
+ }),
},
base::TimeDelta::FromSeconds(1),
base::TimeDelta::FromSeconds(2)),
@@ -242,15 +242,15 @@ TEST_F(CallStackProfileStructTraitsTest, Profile) {
Module(0x4100, "b", base::FilePath()),
},
{
- {
- Frame(0x4010, 0),
- Frame(0x4110, 1),
- Frame(0x4110, Frame::kUnknownModuleIndex),
- },
- {
- Frame(0x4010, 0),
- Frame(0x4110, 2),
- },
+ Sample({
+ Frame(0x4010, 0),
+ Frame(0x4110, 1),
+ Frame(0x4110, Frame::kUnknownModuleIndex),
+ }),
+ Sample({
+ Frame(0x4010, 0),
+ Frame(0x4110, 2),
+ }),
},
base::TimeDelta::FromSeconds(1),
base::TimeDelta::FromSeconds(2)),

Powered by Google App Engine
This is Rietveld 408576698