Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: components/metrics/proto/execution_context.proto

Issue 2444143002: Add process lifetime annotations to stack samples. (Closed)
Patch Set: addressed review comments and finished converting tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/proto/execution_context.proto
diff --git a/components/metrics/proto/execution_context.proto b/components/metrics/proto/execution_context.proto
index 3d8679fe9db2bd8ce69660940c35c7f2416e434a..b982a50ae7e7b7ea39b0a590e40956548fa68c7d 100644
--- a/components/metrics/proto/execution_context.proto
+++ b/components/metrics/proto/execution_context.proto
@@ -47,3 +47,29 @@ enum Thread {
RENDER_THREAD = 9;
UTILITY_THREAD = 10;
}
+
+// Process phases, or where in the lifetime of the process it is such as
+// startup, normal operation, shutdown, etc. These don't necessarily occur in
+// the order defined here so it's fine to add new ones to further segregrate
+// the lifetime of a process.
+enum ProcessPhase {
+ // The browser's main message loop has been started.
+ // Based on histogram Startup.BrowserMainRunnerImplInitializeStep2Time
Mike Wittman 2016/11/16 22:36:10 nit: period at end of comment (and other cases bel
bcwhite 2016/11/16 23:10:49 Done.
+ MAIN_LOOP_START = 0;
+
+ // The beginning of navigation in the first web contents' main frame.
+ // Based on histogram Startup.FirstWebContents.MainNavigationStart
+ MAIN_NAVIGATION_START = 1;
+
+ // The navigation is committed (first bytes received) in the first web
+ // contents' main frame.
+ // Based on histogram Startup.FirstWebContents.MainNavigationFinished
+ MAIN_NAVIGATION_FINISHED = 2;
+
+ // First non-empty paint of the first web contents.
+ // Based on histogram Startup.FirstWebContents.NonEmptyPaint2
+ FIRST_NONEMPTY_PAINT = 3;
+
+ // Process shutdown has begun.
+ SHUTDOWN_START = 4;
+}

Powered by Google App Engine
This is Rietveld 408576698