Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: components/metrics/call_stack_profile_metrics_provider.h

Issue 2444143002: Add process lifetime annotations to stack samples. (Closed)
Patch Set: addressed review comments and finished converting tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/call_stack_profile_metrics_provider.h
diff --git a/components/metrics/call_stack_profile_metrics_provider.h b/components/metrics/call_stack_profile_metrics_provider.h
index bd0b721c8093dc4ad9764d64c74f951932e2b9cb..c44cb753e4ee3d1e65b30795536067ca46f5c31a 100644
--- a/components/metrics/call_stack_profile_metrics_provider.h
+++ b/components/metrics/call_stack_profile_metrics_provider.h
@@ -19,6 +19,31 @@ class ChromeUserMetricsExtension;
// Performs metrics logging for the stack sampling profiler.
class CallStackProfileMetricsProvider : public MetricsProvider {
public:
+ // These phases of a process lifetime can be passed as process "phases" to
+ // StackSmaplingProfile::SetProcessPhase(). Be sure to update the translation
+ // constants at the top of the .cc file when this is changed.
+ enum Phases : int {
+ MAIN_LOOP_START,
+ MAIN_NAVIGATION_START,
+ MAIN_NAVIGATION_FINISHED,
+ FIRST_NONEMPTY_PAINT,
+
+ SHUTDOWN_START,
+
+ PHASES_MAX_VALUE
+ };
+
+ // These common activities that occur within the browser lifetime can be
+ // passed to StackSmaplingProfile::ProcessActivityBegin/End(). Be sure to
+ // update the translation constants at the top of the .cc file when this is
+ // changed.
+ enum Activities : int {
Alexei Svitkine (slow) 2016/11/16 19:10:24 Nit: Remove from this CL.
bcwhite 2016/11/16 23:10:49 Doh! I thought I got them all. <sigh> Done.
Mike Wittman 2016/11/17 17:23:21 Also update the CL description.
bcwhite 2016/11/17 17:43:19 Done.
+ COLLECTING_METRICS,
+ WRITING_PROFILES_STATE,
+
+ ACTIVITIES_MAX_VALUE
+ };
+
CallStackProfileMetricsProvider();
~CallStackProfileMetricsProvider() override;

Powered by Google App Engine
This is Rietveld 408576698