base/profiler/native_stack_sampler.h - Issue 2444143002: Add process lifetime annotations to stack samples.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/profiler/native_stack_sampler.h

Issue 2444143002: Add process lifetime annotations to stack samples. (Closed)

Patch Set: addressed review comments by wittman Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/profiler/native_stack_sampler.h

diff --git a/base/profiler/native_stack_sampler.h b/base/profiler/native_stack_sampler.h

index c7ef84ae31ca8033a09146a1ecb19a831daa4744..d33543f5a99c5b457a932bf0a77a66100d444f79 100644

--- a/base/profiler/native_stack_sampler.h

+++ b/base/profiler/native_stack_sampler.h

@@ -27,6 +27,7 @@ class NativeStackSampler {

// null if this platform does not support stack sampling.

static std::unique_ptr<NativeStackSampler> Create(

PlatformThreadId thread_id,

+ StackSamplingProfiler::AnnotateCallback annotator,

NativeStackSamplerTestDelegate* test_delegate);

// The following functions are all called on the SamplingThread (not the