components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc - Issue 2444143002: Add process lifetime annotations to stack samples.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc

Issue 2444143002: Add process lifetime annotations to stack samples. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/metrics/proto/call_stack_profile.proto ('K') | « components/metrics/public/cpp/call_stack_profile_struct_traits.h ('k') | components/metrics/public/interfaces/call_stack_profile_collector.mojom » ('j') | components/metrics/public/interfaces/call_stack_profile_collector.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc

diff --git a/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc b/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc

index 14db487f452cd61545af8e5f7f617a98f6590234..80856ecf487f3322e44b63e8da711330f0692eb1 100644

--- a/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc

+++ b/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc

@@ -225,9 +225,11 @@ TEST_F(CallStackProfileStructTraitsTest, Profile) {

{

- Frame(0x4010, 0),

- Frame(0x4110, 1),

- Frame(0x4110, Frame::kUnknownModuleIndex),

+ {

+ Frame(0x4010, 0),

+ Frame(0x4110, 1),

+ Frame(0x4110, Frame::kUnknownModuleIndex),

+ }, 0, 0

}

base::TimeDelta::FromSeconds(1),

@@ -243,13 +245,17 @@ TEST_F(CallStackProfileStructTraitsTest, Profile) {

{

- Frame(0x4010, 0),

- Frame(0x4110, 1),

- Frame(0x4110, Frame::kUnknownModuleIndex),

+ {

+ Frame(0x4010, 0),

+ Frame(0x4110, 1),

+ Frame(0x4110, Frame::kUnknownModuleIndex),

+ }, 0, 0,

{

- Frame(0x4010, 0),

- Frame(0x4110, 2),

+ {

+ Frame(0x4010, 0),

+ Frame(0x4110, 2),

+ },

base::TimeDelta::FromSeconds(1),