base/profiler/native_stack_sampler_posix.cc - Issue 2444143002: Add process lifetime annotations to stack samples.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/profiler/native_stack_sampler_posix.cc

Issue 2444143002: Add process lifetime annotations to stack samples. (Closed)

Patch Set: addressed review comments by wittman Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/profiler/native_stack_sampler.h"	5 #include "base/profiler/native_stack_sampler.h"

6	6

7 namespace base {	7 namespace base {

8	8

9 std::unique_ptr<NativeStackSampler> NativeStackSampler::Create(	9 std::unique_ptr<NativeStackSampler> NativeStackSampler::Create(

10 PlatformThreadId thread_id,	10 PlatformThreadId thread_id,

	11 StackSamplingProfiler::AnnotateCallback annotator,

11 NativeStackSamplerTestDelegate* test_delegate) {	12 NativeStackSamplerTestDelegate* test_delegate) {

12 return std::unique_ptr<NativeStackSampler>();	13 return std::unique_ptr<NativeStackSampler>();

13 }	14 }

14	15

15 } // namespace base	16 } // namespace base

OLD	NEW