Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2444103002: Broadcast Channel: Avoid poking at the heap after Blink shutdown (Closed)

Created:
4 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Broadcast Channel: Avoid poking at the heap after Blink shutdown Changes BroadcastChannel::close() to be a no-op if Platform::current() is null. This can happen because MessageLoop destruction may invoke this function indirectly, after Blink has been shut down. TBRing since this precise change was recommended by haraken@ and I'd like to make sure the fix lands ASAP. BUG=658726 TBR=haraken@chromium.org Committed: https://crrev.com/e230c74b0901962437a12b387203e237bfe28e02 Cr-Commit-Position: refs/heads/master@{#427173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444103002/1
4 years, 1 month ago (2016-10-24 20:42:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 22:28:10 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e230c74b0901962437a12b387203e237bfe28e02 Cr-Commit-Position: refs/heads/master@{#427173}
4 years, 1 month ago (2016-10-24 22:32:38 UTC) #7
haraken
4 years, 1 month ago (2016-10-25 05:16:41 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698