Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2444083002: Fix addRequestFinishedListener() documentation (Closed)

Created:
4 years, 1 month ago by mgersh
Modified:
4 years, 1 month ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix addRequestFinishedListener() documentation Calling enableNetworkQualityEstimator() first is no longer required. Committed: https://crrev.com/2d7725478e9be30b818b1f55ccf43bdb5f6fb4c4 Cr-Commit-Position: refs/heads/master@{#427134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mgersh
PTAL
4 years, 1 month ago (2016-10-24 19:10:15 UTC) #2
xunjieli
lgtm
4 years, 1 month ago (2016-10-24 19:21:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444083002/1
4 years, 1 month ago (2016-10-24 19:22:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 20:23:25 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 20:25:33 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2d7725478e9be30b818b1f55ccf43bdb5f6fb4c4
Cr-Commit-Position: refs/heads/master@{#427134}

Powered by Google App Engine
This is Rietveld 408576698