Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 244403002: do not require xscrnsaver on CrOS (Closed)

Created:
6 years, 8 months ago by vapier
Modified:
6 years, 6 months ago
Reviewers:
marcheu, DaveMoore
CC:
chromium-reviews
Visibility:
Public.

Description

do not require xscrnsaver on CrOS We don't use this library in CrOS builds, so do not require it. BUG=chromium:221522 TEST=`cbuildbot amd64-generic-tot-chrome-pfq-informational` works Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273317

Patch Set 1 #

Patch Set 2 : move more behind chromeos==0 #

Patch Set 3 : move x11 files to under chromeos==0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M build/linux/system.gyp View 1 2 2 chunks +21 lines, -17 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vapier
6 years, 7 months ago (2014-05-26 02:51:53 UTC) #1
DaveMoore
lgtm
6 years, 6 months ago (2014-05-28 14:03:13 UTC) #2
vapier
The CQ bit was checked by vapier@chromium.org
6 years, 6 months ago (2014-05-28 15:54:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/244403002/40001
6 years, 6 months ago (2014-05-28 15:54:47 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 19:23:44 UTC) #5
Message was sent while issue was closed.
Change committed as 273317

Powered by Google App Engine
This is Rietveld 408576698