Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2443983003: Refactor ShadowImageSource into ui/gfx/skia_util for better reuse (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
msw, oshima
CC:
chromium-reviews, tfarina, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor ShadowImageSource into ui/gfx/skia_util for better reuse Planning to use it for at least the CrOS system menu UI and browser infobars. BUG=649545, 649802 Committed: https://crrev.com/ec14a768c3422dd386db2db1416a1d83a45a6969 Cr-Commit-Position: refs/heads/master@{#428057}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : remove changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -41 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 4 chunks +5 lines, -41 lines 0 comments Download
M ui/gfx/image/image_skia_operations.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M ui/gfx/image/image_skia_operations.cc View 1 3 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
Evan Stade
4 years, 1 month ago (2016-10-26 17:25:36 UTC) #10
oshima
lgtm
4 years, 1 month ago (2016-10-26 18:50:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443983003/40001
4 years, 1 month ago (2016-10-27 15:38:12 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/291029)
4 years, 1 month ago (2016-10-27 15:46:20 UTC) #19
Evan Stade
+msw for c/b/u/v
4 years, 1 month ago (2016-10-27 15:50:03 UTC) #21
msw
lgtm
4 years, 1 month ago (2016-10-27 16:45:21 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443983003/40001
4 years, 1 month ago (2016-10-27 16:47:01 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-27 16:53:38 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 16:59:32 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ec14a768c3422dd386db2db1416a1d83a45a6969
Cr-Commit-Position: refs/heads/master@{#428057}

Powered by Google App Engine
This is Rietveld 408576698