Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2443983002: Revert of Use the serviceworker with mojo by default (Closed)

Created:
4 years, 1 month ago by dmazzoni
Modified:
4 years, 1 month ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, shimazu+serviceworker_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, kinuko+serviceworker, nhiroki, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, tzik, darin (slow to review), blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use the serviceworker with mojo by default (patchset #2 id:20001 of https://codereview.chromium.org/2436223004/ ) Reason for revert: I think this is causing InstallableManagerBrowserTest.CheckManifest404 to crash, see http://crbug.com/658702 Original issue's description: > Use the serviceworker with mojo by default > > This patch changes --mojo-service-worker to --disable-mojo-service-worker. > Let's try mojo for the service worker. > > BUG=629701 > > Committed: https://crrev.com/391fa63bcefd25b35addf678356828dded5ae71e > Cr-Commit-Position: refs/heads/master@{#427013} TBR=horo@chromium.org,avi@chromium.org,shimazu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629701 Committed: https://crrev.com/cd13e5fd2bc139909075578e71483e0069246eab Cr-Commit-Position: refs/heads/master@{#427088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -21 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 2 chunks +17 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_test_utils.h View 1 chunk +7 lines, -3 lines 0 comments Download
M content/common/service_worker/service_worker_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 2 chunks +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/disable-mojo-service-worker/http/tests/serviceworker/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/virtual/mojo-service-worker/http/tests/serviceworker/README.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dmazzoni
Created Revert of Use the serviceworker with mojo by default
4 years, 1 month ago (2016-10-24 16:44:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443983002/1
4 years, 1 month ago (2016-10-24 16:44:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 16:46:31 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cd13e5fd2bc139909075578e71483e0069246eab Cr-Commit-Position: refs/heads/master@{#427088}
4 years, 1 month ago (2016-10-24 16:50:08 UTC) #7
shimazu
4 years, 1 month ago (2016-11-07 01:52:47 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2477223002/ by shimazu@chromium.org.

The reason for reverting is: Hopefully fixed the issue on
https://crbug.com/658702.

It was a flaky bug, so let's keep our eyes open for the flakiness dashboard for
several days..

Powered by Google App Engine
This is Rietveld 408576698