Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2443963002:
Roll clang 283753:284979. (Closed)
|
Created:
4 years, 1 month ago by Nico Modified:
4 years, 1 month ago Reviewers:
hans CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 283753:284979.
Ran `tools/clang/scripts/upload_revision.py 284979`.
BUG=656667
Committed: https://crrev.com/5e529e0684b9ea3064fe944cee6635824dc97a67
Cr-Commit-Position: refs/heads/master@{#427269}
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thakis@chromium.org
thakis@chromium.org changed reviewers: + hans@chromium.org
I locally built browser_tests in official mode with this, and the pdf tests don't fail. (They recently stopped failing on ToT too, but the progression range ended a bit later than where we're rolling too, so I figured it'd be good to test this. I verified that the 3 PolicyTests tests fail, so I did indeed do an official build.)
Can you update BUG to point to crbug.com/656667 ? Since the PDF tests are green at ToT hopefully, hopefully this roll picks up whatever fixed them. lgtm
Description was changed from ========== Roll clang 283753:284979. Ran `tools/clang/scripts/upload_revision.py 284979`. BUG= ========== to ========== Roll clang 283753:284979. Ran `tools/clang/scripts/upload_revision.py 284979`. BUG=656667 ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll clang 283753:284979. Ran `tools/clang/scripts/upload_revision.py 284979`. BUG=656667 ========== to ========== Roll clang 283753:284979. Ran `tools/clang/scripts/upload_revision.py 284979`. BUG=656667 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll clang 283753:284979. Ran `tools/clang/scripts/upload_revision.py 284979`. BUG=656667 ========== to ========== Roll clang 283753:284979. Ran `tools/clang/scripts/upload_revision.py 284979`. BUG=656667 Committed: https://crrev.com/5e529e0684b9ea3064fe944cee6635824dc97a67 Cr-Commit-Position: refs/heads/master@{#427269} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5e529e0684b9ea3064fe944cee6635824dc97a67 Cr-Commit-Position: refs/heads/master@{#427269} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
