Introduce isAbstractlyInstantiated to avoid exact masks of abstract classes.

Introduce isAbstractlyInstantiated to avoid exact masks of abstract classes.

Classes can be instantiated directly, abstractly or indirectly:

When [cls] is directly instantiated: This means that at runtime instances of exactly [cls] are assumed to exist.

When [cls] is abstractly instantiated: This means that at runtime instances of [cls] or unknown subclasses of [cls] are assumed to exist.

This is used to mark native and/or reflectable classes as instantiated. For native classes we do not know the exact class that instantiates [cls] so [cls] here represents the root of the subclasses. For reflectable classes we need event abstract classes to be 'live' even though they cannot themselves be instantiated.

When [cls] is indirectly instantiated: This means that a subclass of [cls] is directly or abstractly instantiated.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/b0ecbef3cc976c5b60eafa807a1d9a626658f9b1

[Johnni Winther, 2016-10-24 14:16:07]

Description was changed from

==========
Introduce isAbstractlyInstantiated to avoid exact masks of abstract classes.
==========

to

==========
Introduce isAbstractlyInstantiated to avoid exact masks of abstract classes.

Classes can be instantiated directly, abstractly or indirectly:

When [cls] is directly instantiated: This means that at runtime instances of
exactly [cls] are assumed to exist.

When [cls] is abstractly instantiated: This means that at runtime instances of
[cls] or unknown subclasses of [cls] are assumed to exist.

This is used to mark native and/or reflectable classes as instantiated. For
native classes we do not know the exact class that instantiates [cls] so [cls]
here represents the root of the subclasses. For reflectable classes we need
event abstract classes to be 'live' even though they cannot themselves be
instantiated.

When [cls] is indirectly instantiated: This means that a subclass of [cls] is
directly or abstractly instantiated.
==========

[Johnni Winther, 2016-10-24 14:26:10]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-10-27 13:22:08]

lgtm

https://codereview.chromium.org/2443953002/diff/40001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/class_set.dart (right):

https://codereview.chromium.org/2443953002/diff/40001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:123: /// `true` if [cls] has been
abstractly instantiated.
it would be good to add here the definition of "abstractly instantiated" too, or
add a reference to World.isAbstractlyInstantiated(cls)

https://codereview.chromium.org/2443953002/diff/40001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:124: ///
nit: delete line

https://codereview.chromium.org/2443953002/diff/40001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:137: bool get isRootInstantiated =>
I'm trying to think of other names for this - root-instantiated makes me think
of indirectly-instantiated too. Tough concept to name :)

An idea: "explicitlyInstantiated"?

https://codereview.chromium.org/2443953002/diff/40001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:480: if
(subtypeNode.isDirectlyInstantiated ||
can we use isRootInstantiated here too?

[Johnni Winther, 2016-10-28 06:46:10]

Description was changed from

==========
Introduce isAbstractlyInstantiated to avoid exact masks of abstract classes.

Classes can be instantiated directly, abstractly or indirectly:

When [cls] is directly instantiated: This means that at runtime instances of
exactly [cls] are assumed to exist.

When [cls] is abstractly instantiated: This means that at runtime instances of
[cls] or unknown subclasses of [cls] are assumed to exist.

This is used to mark native and/or reflectable classes as instantiated. For
native classes we do not know the exact class that instantiates [cls] so [cls]
here represents the root of the subclasses. For reflectable classes we need
event abstract classes to be 'live' even though they cannot themselves be
instantiated.

When [cls] is indirectly instantiated: This means that a subclass of [cls] is
directly or abstractly instantiated.
==========

to

==========
Introduce isAbstractlyInstantiated to avoid exact masks of abstract classes.

Classes can be instantiated directly, abstractly or indirectly:

When [cls] is directly instantiated: This means that at runtime instances of
exactly [cls] are assumed to exist.

When [cls] is abstractly instantiated: This means that at runtime instances of
[cls] or unknown subclasses of [cls] are assumed to exist.

This is used to mark native and/or reflectable classes as instantiated. For
native classes we do not know the exact class that instantiates [cls] so [cls]
here represents the root of the subclasses. For reflectable classes we need
event abstract classes to be 'live' even though they cannot themselves be
instantiated.

When [cls] is indirectly instantiated: This means that a subclass of [cls] is
directly or abstractly instantiated.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b0ecbef3cc976c5b60eafa807a1d9a626658f9b1
==========

[Johnni Winther, 2016-10-28 06:46:11]

Committed patchset #4 (id:50001) manually as
b0ecbef3cc976c5b60eafa807a1d9a626658f9b1 (presubmit successful).

[Johnni Winther, 2016-11-01 11:26:35]

https://codereview.chromium.org/2443953002/diff/40001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/class_set.dart (right):

https://codereview.chromium.org/2443953002/diff/40001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:123: /// `true` if [cls] has been
abstractly instantiated.
On 2016/10/27 13:22:07, Siggi Cherem (dart-lang) wrote:
> it would be good to add here the definition of "abstractly instantiated" too,
or
> add a reference to World.isAbstractlyInstantiated(cls)

Done.

https://codereview.chromium.org/2443953002/diff/40001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:124: ///
On 2016/10/27 13:22:07, Siggi Cherem (dart-lang) wrote:
> nit: delete line

Done.

https://codereview.chromium.org/2443953002/diff/40001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:137: bool get isRootInstantiated =>
On 2016/10/27 13:22:07, Siggi Cherem (dart-lang) wrote:
> I'm trying to think of other names for this - root-instantiated makes me think
> of indirectly-instantiated too. Tough concept to name :)
> 
> An idea: "explicitlyInstantiated"?

isExplicitlyInstantiated it is!

https://codereview.chromium.org/2443953002/diff/40001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:480: if
(subtypeNode.isDirectlyInstantiated ||
On 2016/10/27 13:22:07, Siggi Cherem (dart-lang) wrote:
> can we use isRootInstantiated here too?

Done.