Add xmllite and xmpp sources to third_party/

third_party/libjingle_xmpp/xmllite/BUILD.gn

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("../../webrtc/build/webrtc.gni")
+
+group("xmllite") {
+  public_deps = [
+    ":rtc_xmllite",
+  ]
+}
+
+rtc_static_library("rtc_xmllite") {
+  sources = [
+    "qname.cc",
+    "qname.h",
+    "xmlbuilder.cc",
+    "xmlbuilder.h",
+    "xmlconstants.cc",
+    "xmlconstants.h",
+    "xmlelement.cc",
+    "xmlelement.h",
+    "xmlnsstack.cc",
+    "xmlnsstack.h",
+    "xmlparser.cc",
+    "xmlparser.h",
+    "xmlprinter.cc",
+    "xmlprinter.h",
+  ]
+
+  deps = [
+    "//third_party/webrtc/base:rtc_base",
+  ]
+
+  if (rtc_build_expat) {
+    deps += [ "//third_party/expat" ]
+    public_deps = [
+      "//third_party/expat",
+    ]
+  }
+
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from Chrome's Clang plugins.
+    # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+  }
+}
+
+if (rtc_include_tests) {
+  config("xmllite_unittests_config") {
+    # GN orders flags on a target before flags from configs. The default config
+    # adds -Wall, and this flag have to be after -Wall -- so they need to
+    # come from a config and can"t be on the target directly.
+    if (is_clang) {
+      cflags = [
+        "-Wno-missing-braces",
+        "-Wno-sign-compare",
+        "-Wno-unused-const-variable",
+      ]
+    }
+  }
+
+  rtc_test("xmllite_unittests") {
+    configs += [ ":xmplite_unittests_config" ]
+
+    if (!build_with_chromium && is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+    }
+
+    deps = [
+      ":rtc_xmllite",
+      "//testing/gtest",
+      "//third_party/webrtc/base:rtc_base_tests_utils",

[pthatcher2, 2016/12/22 20:33:29]

It's a little unfortunate that this depends on webrtc/base.  Do you think it
would be worth it to copy the relevant files from webrtc/base to
libjingle_xmpp/base?  I noticed these files that it needs:

"webrtc/base/socketaddress.h"
"webrtc/base/sigslot.h"
"webrtc/base/task.h"
"webrtc/base/common.h"
"webrtc/base/firewallsocketserver.h"
"webrtc/base/logging.h"
"webrtc/base/physicalsocketserver.h"
"webrtc/base/taskrunner.h"


This could be done in a follow-up CL, though.

[kjellander_chromium, 2016/12/27 12:49:21]

Yeah, let's do that in follow-up. I posted a note in the bug about this as well.

+    ]
+
+    sources = [
+      "qname_unittest.cc",
+      "xmlbuilder_unittest.cc",
+      "xmlelement_unittest.cc",
+      "xmlnsstack_unittest.cc",
+      "xmlparser_unittest.cc",
+      "xmlprinter_unittest.cc",
+    ]
+  }
+}