Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2443893002: [turbofan] Fix deopt loop in out-of-bounds string element access. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix deopt loop in out-of-bounds string element access. We need to check the KeyedLoadIC state to guard against potential deoptimization loops due to out-of-bounds accesses, because the IC system uses the MEGAMORPHIC state to also signal that there was an out-of-bounds access already. R=jarin@chromium.org Committed: https://crrev.com/6c5fa8b49e5f8c3371ce34118933ea70468b375a Cr-Commit-Position: refs/heads/master@{#40525}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 2 chunks +9 lines, -3 lines 0 comments Download
A test/mjsunit/compiler/deopt-string-outofbounds.js View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Benedikt Meurer
4 years, 1 month ago (2016-10-24 09:20:34 UTC) #1
Jarin
lgtm
4 years, 1 month ago (2016-10-24 09:22:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443893002/1
4 years, 1 month ago (2016-10-24 09:23:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/11010) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-10-24 09:37:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443893002/20001
4 years, 1 month ago (2016-10-24 09:49:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 10:32:17 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:45 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c5fa8b49e5f8c3371ce34118933ea70468b375a
Cr-Commit-Position: refs/heads/master@{#40525}

Powered by Google App Engine
This is Rietveld 408576698