Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2443863002: Improve README.chromium for WPTServe. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 1 month ago
Reviewers:
qyearsley, jsbell
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve README.chromium for WPTServe. Also, wptserve.py shows a warning before certificate expiration. BUG=623613 NOTRY=true Committed: https://crrev.com/a13132dfe41eec9d9c21ecf07c483589b5ffedbd Cr-Commit-Position: refs/heads/master@{#427270}

Patch Set 1 #

Total comments: 3

Patch Set 2 : typo! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
tkent
jsbell@, qyearsley@, please review this.
4 years, 2 months ago (2016-10-24 04:39:10 UTC) #4
jsbell
lgtm with nit https://codereview.chromium.org/2443863002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium File third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium (right): https://codereview.chromium.org/2443863002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium#newcode102 third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium:102: 7. Look at *.pem, and update ...
4 years, 1 month ago (2016-10-24 16:29:32 UTC) #5
qyearsley
Also lgtm with nit https://codereview.chromium.org/2443863002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium File third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium (right): https://codereview.chromium.org/2443863002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium#newcode103 third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium:103: in wptserv.py to new expiration ...
4 years, 1 month ago (2016-10-24 16:35:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443863002/40001
4 years, 1 month ago (2016-10-25 03:52:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-10-25 03:57:21 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 04:01:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a13132dfe41eec9d9c21ecf07c483589b5ffedbd
Cr-Commit-Position: refs/heads/master@{#427270}

Powered by Google App Engine
This is Rietveld 408576698