Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 24438006: Refactor register allocator a little bit (Closed)

Created:
7 years, 2 months ago by haitao.feng
Modified:
7 years, 2 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev, john_johnmccutchan.com
Visibility:
Public.

Description

Refactor register allocator a little bit R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16998

Patch Set 1 #

Patch Set 2 : Change GetNextSpillSlot to use RegisterKind #

Patch Set 3 : One more ASSERT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -63 lines) Patch
M src/arm/lithium-arm.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 4 chunks +8 lines, -7 lines 0 comments Download
M src/lithium-allocator.h View 6 chunks +7 lines, -8 lines 0 comments Download
M src/lithium-allocator.cc View 1 15 chunks +30 lines, -17 lines 0 comments Download
M src/lithium-allocator-inl.h View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M src/mips/lithium-mips.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
src/x64/lithium-x64.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
haitao.feng
Replaced is_double_(bool) with kind_(enum) in LiveRange. We are prototyping SIMD proposal (https://github.com/johnmccutchan/ecmascript_simd) in V8 and ...
7 years, 2 months ago (2013-09-25 07:38:17 UTC) #1
Jakob Kummerow
lgtm
7 years, 2 months ago (2013-09-25 12:57:32 UTC) #2
haitao.feng
Jakob, thanks for the review. Patchset 2 is uploaded to change GetNextSpillSlot to use RegisterKind ...
7 years, 2 months ago (2013-09-25 14:00:39 UTC) #3
haitao.feng
The git cl said: " The following errors occured: Base files missing. Try to upload ...
7 years, 2 months ago (2013-09-26 02:48:55 UTC) #4
Jakob Kummerow
Patch set 3 LGTM.
7 years, 2 months ago (2013-09-27 13:19:49 UTC) #5
haitao.feng
7 years, 2 months ago (2013-09-28 00:48:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r16998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698