Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: Source/testing/runner/TestRunner.h

Issue 24438004: Rename testRunner.dumpAsText(true) to testRunner.dumpAsTextWithPixelResults() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: more tests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/testing/runner/TestRunner.h
diff --git a/Source/testing/runner/TestRunner.h b/Source/testing/runner/TestRunner.h
index 648345a89e54dfb3a221ffcc5ee151a851a69990..262a81d347bd6287aabe3e40352cde97b5fe519c 100644
--- a/Source/testing/runner/TestRunner.h
+++ b/Source/testing/runner/TestRunner.h
@@ -92,6 +92,7 @@ public:
bool sweepHorizontally() const;
bool isPrinting() const;
bool shouldDumpAsText();
+ bool shouldDumpAsTextWithPixelResults();
bool shouldDumpChildFrameScrollPositions() const;
bool shouldDumpChildFramesAsText() const;
void showDevTools();
@@ -318,9 +319,14 @@ private:
// This function sets a flag that tells the test_shell to dump pages as
// plain text, rather than as a text representation of the renderer's state.
- // It takes an optional argument, whether to dump pixels results or not.
+ // The pixel results will not be generated for this test.
void dumpAsText(const CppArgumentList&, CppVariant*);
+ // This function sets a flag that tells the test_shell to dump pages as
+ // plain text, rather than as a text representation of the renderer's state.
+ // It will also generate a pixel dump for the test.
+ void dumpAsTextWithPixelResults(const CppArgumentList&, CppVariant*);
+
// This function sets a flag that tells the test_shell to print out the
// scroll offsets of the child frames. It ignores all.
void dumpChildFrameScrollPositions(const CppArgumentList&, CppVariant*);
« no previous file with comments | « LayoutTests/transforms/3d/general/transform-origin-z-change.html ('k') | Source/testing/runner/TestRunner.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698