Remove stl_util's deletion function use from components/url_matcher/.

Remove stl_util's deletion function use from components/url_matcher/.

BUG=555865
Committed: https://crrev.com/bb99de2b02d28fd22b82649e41eced0ee7e51715
Cr-Commit-Position: refs/heads/master@{#427170}

[Avi (use Gerrit), 2016-10-22 23:02:57]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-22 23:03:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 23:45:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 23:45:48]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-10-22 23:54:22]

avi@chromium.org changed reviewers:
+ battre@chromium.org

[battre, 2016-10-24 11:32:16]

https://codereview.chromium.org/2443753003/diff/1/components/url_matcher/rege...
File components/url_matcher/regex_set_matcher.cc (right):

https://codereview.chromium.org/2443753003/diff/1/components/url_matcher/rege...
components/url_matcher/regex_set_matcher.cc:113: void
RegexSetMatcher::DeleteSubstringPatterns() {
I think here should go call to substring_patterns_.clear(); Otherwise, the
vector keeps growing.

https://codereview.chromium.org/2443753003/diff/1/components/url_matcher/url_...
File components/url_matcher/url_matcher.cc (right):

https://codereview.chromium.org/2443753003/diff/1/components/url_matcher/url_...
components/url_matcher/url_matcher.cc:498: StringPattern search_pattern(pattern,
id_counter_++);
why did you change this?

[Avi (use Gerrit), 2016-10-24 14:37:56]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2016-10-24 14:38:06]

https://codereview.chromium.org/2443753003/diff/1/components/url_matcher/rege...
File components/url_matcher/regex_set_matcher.cc (right):

https://codereview.chromium.org/2443753003/diff/1/components/url_matcher/rege...
components/url_matcher/regex_set_matcher.cc:113: void
RegexSetMatcher::DeleteSubstringPatterns() {
On 2016/10/24 11:32:16, battre wrote:
> I think here should go call to substring_patterns_.clear(); Otherwise, the
> vector keeps growing.

Agreed. I missed that this wasn't a destructor.

https://codereview.chromium.org/2443753003/diff/1/components/url_matcher/url_...
File components/url_matcher/url_matcher.cc (right):

https://codereview.chromium.org/2443753003/diff/1/components/url_matcher/url_...
components/url_matcher/url_matcher.cc:498: StringPattern search_pattern(pattern,
id_counter_++);
On 2016/10/24 11:32:16, battre wrote:
> why did you change this?

Gah. It was a remnant of an earlier attempt to fix a problem that I abandoned.

Reverted.

[commit-bot: I haz the power, 2016-10-24 14:38:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 15:48:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 15:48:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-10-24 15:50:06]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 15:50:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[battre, 2016-10-24 16:46:38]

lgtm

[Avi (use Gerrit), 2016-10-24 17:03:04]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2016-10-24 17:03:10]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-10-24 17:03:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 19:08:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 19:08:12]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Avi (use Gerrit), 2016-10-24 20:39:20]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-10-24 20:40:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:22:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-24 22:25:28]

Description was changed from

==========
Remove stl_util's deletion function use from components/url_matcher/.

BUG=555865
==========

to

==========
Remove stl_util's deletion function use from components/url_matcher/.

BUG=555865

Committed: https://crrev.com/bb99de2b02d28fd22b82649e41eced0ee7e51715
Cr-Commit-Position: refs/heads/master@{#427170}
==========

[commit-bot: I haz the power, 2016-10-24 22:25:30]

Patchset 2 (id:??) landed as
https://crrev.com/bb99de2b02d28fd22b82649e41eced0ee7e51715
Cr-Commit-Position: refs/heads/master@{#427170}