Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: third_party/WebKit/Source/web/tests/ViewportTest.cpp

Issue 2443753002: Count presence of viewport tag as mobile-friendly
Patch Set: default false Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 2926 matching lines...) Expand 10 before | Expand all | Expand 10 after
2937 TEST_F(ViewportTest, viewportTriggersGpuRasterization) { 2937 TEST_F(ViewportTest, viewportTriggersGpuRasterization) {
2938 FrameTestHelpers::WebViewHelper webViewHelper; 2938 FrameTestHelpers::WebViewHelper webViewHelper;
2939 2939
2940 registerMockedHttpURLLoad( 2940 registerMockedHttpURLLoad(
2941 "viewport/viewport-gpu-rasterization-disabled-without-viewport.html"); 2941 "viewport/viewport-gpu-rasterization-disabled-without-viewport.html");
2942 webViewHelper.initializeAndLoad( 2942 webViewHelper.initializeAndLoad(
2943 m_baseURL + 2943 m_baseURL +
2944 "viewport/viewport-gpu-rasterization-disabled-without-viewport.html", 2944 "viewport/viewport-gpu-rasterization-disabled-without-viewport.html",
2945 true, nullptr, nullptr, nullptr, setViewportSettings); 2945 true, nullptr, nullptr, nullptr, setViewportSettings);
2946 webViewHelper.webView()->resize(WebSize(640, 480)); 2946 webViewHelper.webView()->resize(WebSize(640, 480));
2947 EXPECT_FALSE(webViewHelper.webView() 2947 EXPECT_TRUE(webViewHelper.webView()->isDesktopSiteOnMobileForTesting());
2948 ->matchesHeuristicsForGpuRasterizationForTesting());
2949 // Also test that setting enableViewport to false (as on desktop Chrome) 2948 // Also test that setting enableViewport to false (as on desktop Chrome)
2950 // supports GPU raster unconditionally. 2949 // supports GPU raster unconditionally.
2951 webViewHelper.initializeAndLoad( 2950 webViewHelper.initializeAndLoad(
2952 m_baseURL + 2951 m_baseURL +
2953 "viewport/viewport-gpu-rasterization-disabled-without-viewport.html", 2952 "viewport/viewport-gpu-rasterization-disabled-without-viewport.html",
2954 true); 2953 true);
2955 webViewHelper.webView()->resize(WebSize(640, 480)); 2954 webViewHelper.webView()->resize(WebSize(640, 480));
2956 EXPECT_TRUE(webViewHelper.webView() 2955 EXPECT_FALSE(webViewHelper.webView()->isDesktopSiteOnMobileForTesting());
2957 ->matchesHeuristicsForGpuRasterizationForTesting());
2958 2956
2959 registerMockedHttpURLLoad("viewport/viewport-gpu-rasterization.html"); 2957 registerMockedHttpURLLoad("viewport/viewport-gpu-rasterization.html");
2960 webViewHelper.initializeAndLoad( 2958 webViewHelper.initializeAndLoad(
2961 m_baseURL + "viewport/viewport-gpu-rasterization.html", true, nullptr, 2959 m_baseURL + "viewport/viewport-gpu-rasterization.html", true, nullptr,
2962 nullptr, nullptr, setViewportSettings); 2960 nullptr, nullptr, setViewportSettings);
2963 webViewHelper.webView()->resize(WebSize(640, 480)); 2961 webViewHelper.webView()->resize(WebSize(640, 480));
2964 EXPECT_TRUE(webViewHelper.webView() 2962 EXPECT_FALSE(webViewHelper.webView()->isDesktopSiteOnMobileForTesting());
2965 ->matchesHeuristicsForGpuRasterizationForTesting());
2966 2963
2967 registerMockedHttpURLLoad( 2964 registerMockedHttpURLLoad(
2968 "viewport/viewport-gpu-rasterization-expanded-heuristics.html"); 2965 "viewport/viewport-gpu-rasterization-expanded-heuristics.html");
2969 webViewHelper.initializeAndLoad( 2966 webViewHelper.initializeAndLoad(
2970 m_baseURL + 2967 m_baseURL +
2971 "viewport/viewport-gpu-rasterization-expanded-heuristics.html", 2968 "viewport/viewport-gpu-rasterization-expanded-heuristics.html",
2972 true, nullptr, nullptr, nullptr, setViewportSettings); 2969 true, nullptr, nullptr, nullptr, setViewportSettings);
2973 webViewHelper.webView()->resize(WebSize(640, 480)); 2970 webViewHelper.webView()->resize(WebSize(640, 480));
2974 EXPECT_TRUE(webViewHelper.webView() 2971 EXPECT_FALSE(webViewHelper.webView()->isDesktopSiteOnMobileForTesting());
2975 ->matchesHeuristicsForGpuRasterizationForTesting());
2976 2972
2977 registerMockedHttpURLLoad("viewport/viewport-1.html"); 2973 registerMockedHttpURLLoad("viewport/viewport-1.html");
2978 webViewHelper.initializeAndLoad(m_baseURL + "viewport/viewport-1.html", true, 2974 webViewHelper.initializeAndLoad(m_baseURL + "viewport/viewport-1.html", true,
2979 nullptr, nullptr, nullptr, 2975 nullptr, nullptr, nullptr,
2980 setViewportSettings); 2976 setViewportSettings);
2981 webViewHelper.webView()->resize(WebSize(640, 480)); 2977 webViewHelper.webView()->resize(WebSize(640, 480));
2982 EXPECT_TRUE(webViewHelper.webView() 2978 EXPECT_FALSE(webViewHelper.webView()->isDesktopSiteOnMobileForTesting());
2983 ->matchesHeuristicsForGpuRasterizationForTesting());
2984 2979
2985 registerMockedHttpURLLoad("viewport/viewport-15.html"); 2980 registerMockedHttpURLLoad("viewport/viewport-15.html");
2986 webViewHelper.initializeAndLoad(m_baseURL + "viewport/viewport-15.html", true, 2981 webViewHelper.initializeAndLoad(m_baseURL + "viewport/viewport-15.html", true,
2987 nullptr, nullptr, nullptr, 2982 nullptr, nullptr, nullptr,
2988 setViewportSettings); 2983 setViewportSettings);
2989 webViewHelper.webView()->resize(WebSize(640, 480)); 2984 webViewHelper.webView()->resize(WebSize(640, 480));
2990 EXPECT_TRUE(webViewHelper.webView() 2985 EXPECT_FALSE(webViewHelper.webView()->isDesktopSiteOnMobileForTesting());
2991 ->matchesHeuristicsForGpuRasterizationForTesting());
2992 2986
2993 registerMockedHttpURLLoad("viewport/viewport-130.html"); 2987 registerMockedHttpURLLoad("viewport/viewport-130.html");
2994 webViewHelper.initializeAndLoad(m_baseURL + "viewport/viewport-130.html", 2988 webViewHelper.initializeAndLoad(m_baseURL + "viewport/viewport-130.html",
2995 true, nullptr, nullptr, nullptr, 2989 true, nullptr, nullptr, nullptr,
2996 setViewportSettings); 2990 setViewportSettings);
2997 webViewHelper.webView()->resize(WebSize(640, 480)); 2991 webViewHelper.webView()->resize(WebSize(640, 480));
2998 EXPECT_TRUE(webViewHelper.webView() 2992 EXPECT_FALSE(webViewHelper.webView()->isDesktopSiteOnMobileForTesting());
2999 ->matchesHeuristicsForGpuRasterizationForTesting());
3000 2993
3001 registerMockedHttpURLLoad("viewport/viewport-legacy-handheldfriendly.html"); 2994 registerMockedHttpURLLoad("viewport/viewport-legacy-handheldfriendly.html");
3002 webViewHelper.initializeAndLoad( 2995 webViewHelper.initializeAndLoad(
3003 m_baseURL + "viewport/viewport-legacy-handheldfriendly.html", true, 2996 m_baseURL + "viewport/viewport-legacy-handheldfriendly.html", true,
3004 nullptr, nullptr, nullptr, setViewportSettings); 2997 nullptr, nullptr, nullptr, setViewportSettings);
3005 webViewHelper.webView()->resize(WebSize(640, 480)); 2998 webViewHelper.webView()->resize(WebSize(640, 480));
3006 EXPECT_TRUE(webViewHelper.webView() 2999 EXPECT_FALSE(webViewHelper.webView()->isDesktopSiteOnMobileForTesting());
3007 ->matchesHeuristicsForGpuRasterizationForTesting());
3008 3000
3009 registerMockedHttpURLLoad("viewport/viewport-legacy-mobileoptimized.html"); 3001 registerMockedHttpURLLoad("viewport/viewport-legacy-mobileoptimized.html");
3010 webViewHelper.initializeAndLoad( 3002 webViewHelper.initializeAndLoad(
3011 m_baseURL + "viewport/viewport-legacy-handheldfriendly.html", true, 3003 m_baseURL + "viewport/viewport-legacy-handheldfriendly.html", true,
3012 nullptr, nullptr, nullptr, setViewportSettings); 3004 nullptr, nullptr, nullptr, setViewportSettings);
3013 webViewHelper.webView()->resize(WebSize(640, 480)); 3005 webViewHelper.webView()->resize(WebSize(640, 480));
3014 EXPECT_TRUE(webViewHelper.webView() 3006 EXPECT_FALSE(webViewHelper.webView()->isDesktopSiteOnMobileForTesting());
3015 ->matchesHeuristicsForGpuRasterizationForTesting());
3016 } 3007 }
3017 3008
3018 class ConsoleMessageWebFrameClient 3009 class ConsoleMessageWebFrameClient
3019 : public FrameTestHelpers::TestWebFrameClient { 3010 : public FrameTestHelpers::TestWebFrameClient {
3020 public: 3011 public:
3021 virtual void didAddMessageToConsole(const WebConsoleMessage& msg, 3012 virtual void didAddMessageToConsole(const WebConsoleMessage& msg,
3022 const WebString& sourceName, 3013 const WebString& sourceName,
3023 unsigned sourceLine, 3014 unsigned sourceLine,
3024 const WebString& stackTrace) { 3015 const WebString& stackTrace) {
3025 messages.append(msg); 3016 messages.append(msg);
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
3199 m_baseURL + "viewport/viewport-warnings-7.html", true, &webFrameClient, 3190 m_baseURL + "viewport/viewport-warnings-7.html", true, &webFrameClient,
3200 nullptr, nullptr, setViewportSettings); 3191 nullptr, nullptr, setViewportSettings);
3201 3192
3202 Page* page = webViewHelper.webView()->page(); 3193 Page* page = webViewHelper.webView()->page();
3203 runViewportTest(page, 320, 352); 3194 runViewportTest(page, 320, 352);
3204 3195
3205 EXPECT_EQ(0U, webFrameClient.messages.size()); 3196 EXPECT_EQ(0U, webFrameClient.messages.size());
3206 } 3197 }
3207 3198
3208 } // namespace blink 3199 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698