Count presence of viewport tag as mobile-friendly

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 399 matching lines @@
       m_imeAcceptEvents(true),
       m_operationsAllowed(WebDragOperationNone),
       m_dragOperation(WebDragOperationNone),
       m_devToolsEmulator(nullptr),
       m_isTransparent(false),
       m_tabsToLinks(false),
       m_layerTreeView(nullptr),
       m_rootLayer(nullptr),
       m_rootGraphicsLayer(nullptr),
       m_visualViewportContainerLayer(nullptr),
-      m_matchesHeuristicsForGpuRasterization(false),
+      m_isDesktopSiteOnMobile(true),

[aelias_OOO_until_Jul13, 2016/10/28 21:43:46]

Hmm, this has a slight risk of activating intended-to-be-Clank-specific code on
desktop platforms in a brief time window early in loading.  I don't think that
could make any difference with the current featureset tied to this boolean, but
I'd be more comfortable with a default of "false".

[wychen, 2016/10/28 23:07:36]

Done.

       m_flingModifier(0),
       m_flingSourceDevice(WebGestureDeviceUninitialized),
       m_fullscreenController(FullscreenController::create(this)),
       m_baseBackgroundColor(Color::white),
       m_backgroundColorOverride(Color::transparent),
       m_zoomFactorOverride(0),
       m_userGestureObserved(false),
       m_shouldDispatchFirstVisuallyNonEmptyLayout(false),
       m_shouldDispatchFirstLayoutAfterFinishedParsing(false),
       m_shouldDispatchFirstLayoutAfterFinishedLoading(false),
@@ skipping 431 matching lines @@
 
       // Don't trigger a disambiguation popup on sites designed for mobile
       // devices.  Instead, assume that the page has been designed with big
       // enough buttons and links.  Don't trigger a disambiguation popup when
       // screencasting, since it's implemented outside of compositor pipeline
       // and is not being screencasted itself. This leads to bad user
       // experience.
       WebDevToolsAgentImpl* devTools = mainFrameDevToolsAgentImpl();
       VisualViewport& visualViewport = page()->frameHost().visualViewport();
       bool screencastEnabled = devTools && devTools->screencastEnabled();
-      if (event.data.tap.width > 0 &&
-          !visualViewport.shouldDisableDesktopWorkarounds() &&
+      if (event.data.tap.width > 0 && m_isDesktopSiteOnMobile &&
           !screencastEnabled) {
         IntRect boundingBox(visualViewport.viewportToRootFrame(
             IntRect(event.x - event.data.tap.width / 2,
                     event.y - event.data.tap.height / 2, event.data.tap.width,
                     event.data.tap.height)));
 
         // TODO(bokan): We shouldn't pass details of the VisualViewport offset
         // to render_view_impl.  crbug.com/459591
         WebSize visualViewportOffset =
             flooredIntSize(visualViewport.scrollOffset());
@@ skipping 2050 matching lines @@
   if (!frame || !frame->view() || !element)
     return false;
 
   if (!isElementEditable(element))
     return false;
 
   element->document().updateStyleAndLayoutIgnorePendingStylesheets();
 
   bool zoomInToLegibleScale =
       m_webSettings->autoZoomFocusedNodeToLegibleScale() &&
-      !page()->frameHost().visualViewport().shouldDisableDesktopWorkarounds();
+      m_isDesktopSiteOnMobile;
 
   if (zoomInToLegibleScale) {
     // When deciding whether to zoom in on a focused text box, we should decide
     // not to zoom in if the user won't be able to zoom out. e.g if the textbox
     // is within a touch-action: none container the user can't zoom back out.
     TouchAction action = TouchActionUtil::computeEffectiveTouchAction(*element);
     if (!(action & TouchActionPinchZoom))
       zoomInToLegibleScale = false;
   }
 
@@ skipping 395 matching lines @@
     const ViewportDescription& description) {
   if (!page() || (!m_size.width && !m_size.height) ||
       !page()->mainFrame()->isLocalFrame())
     return;
 
   if (!settings()->viewportEnabled()) {
     pageScaleConstraintsSet().clearPageDefinedConstraints();
     updateMainFrameLayoutSize();
 
     // If we don't support mobile viewports, allow GPU rasterization.
-    m_matchesHeuristicsForGpuRasterization = true;
-    if (m_layerTreeView)
+    m_isDesktopSiteOnMobile = false;
+    if (m_layerTreeView) {
       m_layerTreeView->heuristicsForGpuRasterizationUpdated(
-          m_matchesHeuristicsForGpuRasterization);
+          !m_isDesktopSiteOnMobile);
+    }
     return;
   }
 
   Document* document = page()->deprecatedLocalMainFrame()->document();
 
-  m_matchesHeuristicsForGpuRasterization =
-      description.matchesHeuristicsForGpuRasterization();
-  if (m_layerTreeView)
+  m_isDesktopSiteOnMobile = !description.isSpecifiedByAuthor();
+  if (m_layerTreeView) {
     m_layerTreeView->heuristicsForGpuRasterizationUpdated(
-        m_matchesHeuristicsForGpuRasterization);
+        !m_isDesktopSiteOnMobile);
+  }
 
   Length defaultMinWidth = document->viewportDefaultMinWidth();
   if (defaultMinWidth.isAuto())
     defaultMinWidth = Length(ExtendToZoom);
 
   ViewportDescription adjustedDescription = description;
   if (settingsImpl()->viewportMetaLayoutSizeQuirk() &&
       adjustedDescription.type == ViewportDescription::ViewportMeta) {
     const int legacyWidthSnappingMagicNumber = 320;
     if (adjustedDescription.maxWidth.isFixed() &&
@@ skipping 1167 matching lines @@
   if (focusedFrame->localFrameRoot() != mainFrameImpl()->frame())
     return nullptr;
   return focusedFrame;
 }
 
 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const {
   return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr;
 }
 
 }  // namespace blink