Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2443723002: Rename IFX_ stream names (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename IFX_ stream names It's been troubling for some time that an IFX_FileStream might actually be an in-memory buffer with no backing file. Committed: https://pdfium.googlesource.com/pdfium/+/ad2441ef675866eb84c7392eeda03391a5a5d474

Patch Set 1 #

Patch Set 2 : Terse #

Total comments: 2

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -226 lines) Patch
M core/fpdfapi/edit/cpdf_creator.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/edit/fpdf_edit_create.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/page/cpdf_image.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/page/cpdf_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cfdf_document.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cfdf_document.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_parser.h View 4 chunks +7 lines, -5 lines 0 comments Download
M core/fpdfapi/parser/cpdf_parser.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M core/fpdfapi/parser/cpdf_parser_unittest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_stream.h View 2 chunks +3 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_stream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_syntax_parser.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_syntax_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/fpdf_parser_utility.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/fpdf_parser_utility.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/ccodec_progressivedecoder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fxcodec/codec/ccodec_tiffmodule.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxcodec/codec/fx_codec_progress.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_tiff.cpp View 5 chunks +6 lines, -5 lines 0 comments Download
M core/fxcrt/extension.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M core/fxcrt/fx_basic.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxcrt/fx_basic_buffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_ext.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_extension.cpp View 1 4 chunks +9 lines, -8 lines 0 comments Download
M core/fxcrt/fx_stream.h View 1 7 chunks +31 lines, -28 lines 0 comments Download
M core/fxcrt/fx_xml.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_xml_parser.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fxcrt/fxcrt_stream.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M core/fxcrt/xml_int.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fxge/android/cfpf_skiafontmgr.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M core/fxge/android/fpf_skiafontmgr.h View 2 chunks +3 lines, -2 lines 0 comments Download
M core/fxge/fx_font.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/cfx_font.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/cpdfsdk_formfillenvironment.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_formfillenvironment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_dataavail.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfeditimg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 3 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_app.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_app.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_define.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M testing/libfuzzer/pdf_cfx_saxreader_fuzzer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M testing/libfuzzer/xfa_codec_fuzzer.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/xml/cfx_saxreader.h View 2 chunks +5 lines, -3 lines 0 comments Download
M xfa/fde/xml/cfx_saxreader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.h View 2 chunks +6 lines, -4 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.cpp View 13 chunks +19 lines, -17 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.h View 2 chunks +7 lines, -7 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 12 chunks +15 lines, -12 lines 0 comments Download
M xfa/fxfa/app/xfa_checksum.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 5 chunks +6 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fxfa.h View 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_dataexporter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_dataexporter.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/parser/cxfa_dataimporter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_dataimporter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_document_parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_document_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_simple_parser.h View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_simple_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/xfa_checksum.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/xfa_ffapp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/xfa_ffdoc.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/xfa_ffwidget.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Tom Sepez
Lei, nothing but sed. Review the change in fx_stream.h.
4 years, 1 month ago (2016-10-21 22:22:17 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/2443723002/diff/20001/core/fpdfapi/page/cpdf_image.h File core/fpdfapi/page/cpdf_image.h (right): https://codereview.chromium.org/2443723002/diff/20001/core/fpdfapi/page/cpdf_image.h#newcode24 core/fpdfapi/page/cpdf_image.h:24: class IFX_SeekableReadStream; No longer in alphabetical order.
4 years, 1 month ago (2016-10-22 01:18:03 UTC) #3
Tom Sepez
https://codereview.chromium.org/2443723002/diff/20001/core/fpdfapi/page/cpdf_image.h File core/fpdfapi/page/cpdf_image.h (right): https://codereview.chromium.org/2443723002/diff/20001/core/fpdfapi/page/cpdf_image.h#newcode24 core/fpdfapi/page/cpdf_image.h:24: class IFX_SeekableReadStream; On 2016/10/22 01:18:03, Lei Zhang wrote: > ...
4 years, 1 month ago (2016-10-24 16:17:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443723002/40001
4 years, 1 month ago (2016-10-24 16:18:43 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 17:19:15 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/ad2441ef675866eb84c7392eeda03391a5a5...

Powered by Google App Engine
This is Rietveld 408576698