Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2443703002:
Remove old tokens for DMA-BUF import modifiers. (Closed)
DescriptionRemove old tokens for DMA-BUF import modifiers.
We have already landed the NVIDIA driver updates, so removing the temporary
workaround in chrome and the old token definitions in the header.
BUG=chrome-os-partner:58718
TEST=nyan_big boots to login
TBR=kbr@chromium.org
Committed: https://crrev.com/a3064d1ad576f2349db8d019abc191a81e29f3ff
Cr-Commit-Position: refs/heads/master@{#426925}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 20 (11 generated)
hshi@chromium.org changed reviewers: + hoegsberg@chromium.org, kbr@chromium.org, marcheu@chromium.org, rjkroege@chromium.org
PTAL. Now that Chrome canary has uprev'd to 56.0.2897.0 I have already landed the NV 2016.10.13 drivers this morning and verified that nyan_big is working with the new enums. marcheu, hoegsberg (FYI) kbr, rjkroege (OWNERS)
The CQ bit was checked by hshi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hoegsberg@google.com changed reviewers: + hoegsberg@google.com
Looks good to me, thanks for doing the update.
Looks good to me, thanks for doing the update.
lgtm
lgtm
Description was changed from ========== Remove old tokens for DMA-BUF import modifiers. We have already landed the NVIDIA driver updates, so removing the temporary workaround in chrome and the old token definitions in the header. BUG=chrome-os-partner:58718 TEST=nyan_big boots to login ========== to ========== Remove old tokens for DMA-BUF import modifiers. We have already landed the NVIDIA driver updates, so removing the temporary workaround in chrome and the old token definitions in the header. BUG=chrome-os-partner:58718 TEST=nyan_big boots to login TBR=kbr ==========
Description was changed from ========== Remove old tokens for DMA-BUF import modifiers. We have already landed the NVIDIA driver updates, so removing the temporary workaround in chrome and the old token definitions in the header. BUG=chrome-os-partner:58718 TEST=nyan_big boots to login TBR=kbr ========== to ========== Remove old tokens for DMA-BUF import modifiers. We have already landed the NVIDIA driver updates, so removing the temporary workaround in chrome and the old token definitions in the header. BUG=chrome-os-partner:58718 TEST=nyan_big boots to login TBR=kbr@chromium.org ==========
lgtm https://codereview.chromium.org/2443703002/diff/1/third_party/khronos/EGL/egl... File third_party/khronos/EGL/eglext.h (right): https://codereview.chromium.org/2443703002/diff/1/third_party/khronos/EGL/egl... third_party/khronos/EGL/eglext.h:581: #ifndef EGL_EXT_image_dma_buf_import_modifiers Same comment as earlier about upstreaming these tokens to Khronos' repository if that hasn't been done already.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hshi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove old tokens for DMA-BUF import modifiers. We have already landed the NVIDIA driver updates, so removing the temporary workaround in chrome and the old token definitions in the header. BUG=chrome-os-partner:58718 TEST=nyan_big boots to login TBR=kbr@chromium.org ========== to ========== Remove old tokens for DMA-BUF import modifiers. We have already landed the NVIDIA driver updates, so removing the temporary workaround in chrome and the old token definitions in the header. BUG=chrome-os-partner:58718 TEST=nyan_big boots to login TBR=kbr@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove old tokens for DMA-BUF import modifiers. We have already landed the NVIDIA driver updates, so removing the temporary workaround in chrome and the old token definitions in the header. BUG=chrome-os-partner:58718 TEST=nyan_big boots to login TBR=kbr@chromium.org ========== to ========== Remove old tokens for DMA-BUF import modifiers. We have already landed the NVIDIA driver updates, so removing the temporary workaround in chrome and the old token definitions in the header. BUG=chrome-os-partner:58718 TEST=nyan_big boots to login TBR=kbr@chromium.org Committed: https://crrev.com/a3064d1ad576f2349db8d019abc191a81e29f3ff Cr-Commit-Position: refs/heads/master@{#426925} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a3064d1ad576f2349db8d019abc191a81e29f3ff Cr-Commit-Position: refs/heads/master@{#426925} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
