Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issue 2443643002: MB: Add --isolate-map-file flag for overriding default isolate map. (Closed)

Created:
4 years, 2 months ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MB: Add --isolate-map-file flag for overriding default isolate map. With this flag it will be possible for client projects also using swarming to keep the isolate map file in their own repo. BUG=497757 Committed: https://crrev.com/902bcb6d4b3d79d5d8b3744ec512ab27cc130f8d Cr-Commit-Position: refs/heads/master@{#427607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M tools/mb/mb.py View 5 chunks +18 lines, -9 lines 0 comments Download
M tools/mb/mb_unittest.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kjellander_chromium
4 years, 2 months ago (2016-10-21 18:54:18 UTC) #3
ehmaldonado_chromium
On 2016/10/21 18:54:18, kjellander_chromium wrote: It'll also be necessary to modify run_mb (https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/api.py?l=683)
4 years, 1 month ago (2016-10-24 00:13:31 UTC) #4
Dirk Pranke
lgtm. And yes, if you're using chromium.run_mb() you'll need to add the parameter there, too.
4 years, 1 month ago (2016-10-25 23:27:18 UTC) #5
kjellander_chromium
On 2016/10/25 23:27:18, Dirk Pranke (slow) wrote: > lgtm. > > And yes, if you're ...
4 years, 1 month ago (2016-10-26 05:20:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443643002/1
4 years, 1 month ago (2016-10-26 05:20:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 06:21:20 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 06:23:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/902bcb6d4b3d79d5d8b3744ec512ab27cc130f8d
Cr-Commit-Position: refs/heads/master@{#427607}

Powered by Google App Engine
This is Rietveld 408576698