Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2443623002: Fix a download histograms (Closed)

Created:
4 years, 2 months ago by Theresa
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a download histograms Record opening downloads in CCT and fix histogram for download counts. BUG=657542, 657539 Committed: https://crrev.com/d891a23f7a747b31f8edd6f6db2ca09ef62e8d3b Cr-Commit-Position: refs/heads/master@{#427167}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change from dfalcantara@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java View 1 4 chunks +21 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Theresa
ptal
4 years, 2 months ago (2016-10-21 16:47:26 UTC) #4
gone
lgtm https://codereview.chromium.org/2443623002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java File chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java (right): https://codereview.chromium.org/2443623002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java#newcode140 chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:140: if (mLoadingDelegate.isLoaded()) { Probably worth pulling this out ...
4 years, 1 month ago (2016-10-24 17:20:59 UTC) #7
Theresa
https://codereview.chromium.org/2443623002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java File chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java (right): https://codereview.chromium.org/2443623002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java#newcode140 chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:140: if (mLoadingDelegate.isLoaded()) { On 2016/10/24 17:20:59, dfalcantara (slow 10.24) ...
4 years, 1 month ago (2016-10-24 20:34:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443623002/20001
4 years, 1 month ago (2016-10-24 20:34:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 22:14:02 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 22:19:38 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d891a23f7a747b31f8edd6f6db2ca09ef62e8d3b
Cr-Commit-Position: refs/heads/master@{#427167}

Powered by Google App Engine
This is Rietveld 408576698