Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 24436004: MIPS: Turn the NumberToStringStub into a hydrogen stub. (Closed)

Created:
7 years, 3 months ago by palfia
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Turn the NumberToStringStub into a hydrogen stub. Port r16910 (5a0dd952) Original commit message: This adds a BuildLookupNumberStringCache() in Hydrogen, which will be used by the hydrogen version of StringAddStub, in addition to the hydrogen version of NumberToStringStub. BUG= R=plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=16926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -34 lines) Patch
M src/mips/code-stubs-mips.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +10 lines, -15 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
palfia
PTAL.
7 years, 3 months ago (2013-09-25 00:08:19 UTC) #1
Paul Lind
LGTM.
7 years, 3 months ago (2013-09-25 00:26:45 UTC) #2
Paul Lind
LGTM.
7 years, 3 months ago (2013-09-25 00:26:45 UTC) #3
palfia
7 years, 3 months ago (2013-09-25 00:41:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16926 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698