chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc - Issue 24436003: Don't leave renderer process frozen when canceling JavaScript dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc

Issue 24436003: Don't leave renderer process frozen when canceling JavaScript dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc

diff --git a/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc b/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc

index c65a732ceba0cf96993196f6b6f54fb912404664..3369442a5342e0cde8d941bf49a8ff8c6e310477 100644

--- a/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc

+++ b/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc

@@ -108,7 +108,7 @@ void JavaScriptAppModalDialog::Invalidate() {

return;

AppModalDialog::Invalidate();

- callback_.Reset();

+ callback_.Run(false, string16());

if (native_dialog())

CloseModalDialog();

}

« no previous file with comments | « no previous file | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »