Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7108)

Unified Diff: chrome/browser/feedback/feedback_data.cc

Issue 24436002: Remove screen dimensions from image sent with Feedback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/feedback/feedback_data.cc
diff --git a/chrome/browser/feedback/feedback_data.cc b/chrome/browser/feedback/feedback_data.cc
index db60a24b9591f40a0429f38135a23009e4f71af1..658a17df404a349f1eaf4f7989c28bf0df52f471 100644
--- a/chrome/browser/feedback/feedback_data.cc
+++ b/chrome/browser/feedback/feedback_data.cc
@@ -44,14 +44,7 @@ std::string LogsToString(FeedbackData::SystemLogsMap* sys_info) {
std::string key = it->first;
std::string value = it->second;
- // Screensize info is sent with every report to remember the window size
- // for when feedback was invoked. This is a hack needed to know what
- // dimensions the user screenshot is since the actual screenshot mechanism
- // in JS doesn't give us the dimensions of the screenshot taken. These
- // values shouldn't be sent with the report.
- if (key == FeedbackData::kScreensizeHeightKey ||
- key == FeedbackData::kScreensizeWidthKey ||
- FeedbackData::BelowCompressionThreshold(value))
+ if (FeedbackData::BelowCompressionThreshold(value))
continue;
TrimString(key, "\n ", &key);
@@ -83,11 +76,6 @@ void ZipLogs(FeedbackData::SystemLogsMap* sys_info,
} // namespace
// static
-const char FeedbackData::kScreensizeHeightKey[] = "ScreensizeHeight";
-// static
-const char FeedbackData::kScreensizeWidthKey[] = "ScreensizeWidth";
-
-// static
bool FeedbackData::BelowCompressionThreshold(const std::string& content) {
if (content.length() > kFeedbackMaxLength)
return false;

Powered by Google App Engine
This is Rietveld 408576698