Factor out AudioOutputDelegate from AudioRendererHost.

content/browser/browser_main_loop.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_main_loop.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
@@ skipping 25 matching lines @@
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/timer/hi_res_timer_manager.h"
 #include "base/trace_event/memory_dump_manager.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
 #include "components/discardable_memory/service/discardable_shared_memory_manager.h"
 #include "components/tracing/browser/trace_config_file.h"
 #include "components/tracing/common/process_metrics_memory_dump_provider.h"
 #include "components/tracing/common/trace_to_console.h"
 #include "components/tracing/common/tracing_switches.h"
+#include "content/browser/audio_device_thread.h"
 #include "content/browser/browser_thread_impl.h"
 #include "content/browser/device_sensors/device_sensor_service.h"
 #include "content/browser/dom_storage/dom_storage_area.h"
 #include "content/browser/download/download_resource_handler.h"
 #include "content/browser/download/save_file_manager.h"
 #include "content/browser/gamepad/gamepad_service.h"
 #include "content/browser/gpu/browser_gpu_channel_host_factory.h"
 #include "content/browser/gpu/browser_gpu_memory_buffer_manager.h"
 #include "content/browser/gpu/compositor_util.h"
 #include "content/browser/gpu/gpu_data_manager_impl.h"
@@ skipping 1546 matching lines @@
           base::Bind(OnStoppedStartupTracing, startup_trace_file_)));
 }
 
 void BrowserMainLoop::CreateAudioManager() {
   DCHECK(!audio_thread_);
   DCHECK(!audio_manager_);
 
   audio_manager_ = GetContentClient()->browser()->CreateAudioManager(
       MediaInternals::GetInstance());
   if (!audio_manager_) {
-    audio_thread_.reset(new base::Thread("AudioThread"));
-#if defined(OS_WIN)
-    audio_thread_->init_com_with_mta(true);
-#endif  // defined(OS_WIN)
-    CHECK(audio_thread_->Start());
-#if defined(OS_MACOSX)
-    // On Mac audio task runner must belong to the main thread.
-    // See http://crbug.com/158170.
-    scoped_refptr<base::SingleThreadTaskRunner> audio_task_runner =
-        base::ThreadTaskRunnerHandle::Get();
-#else
-    scoped_refptr<base::SingleThreadTaskRunner> audio_task_runner =
-        audio_thread_->task_runner();
-#endif  // defined(OS_MACOSX)
-    scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner =
-        audio_thread_->task_runner();
-    audio_manager_ = media::AudioManager::Create(std::move(audio_task_runner),
-                                                 std::move(worker_task_runner),
-                                                 MediaInternals::GetInstance());
+    audio_thread_ = base::MakeUnique<AudioDeviceThread>();
+    audio_manager_ = media::AudioManager::Create(
+        audio_thread_->task_runner(), audio_thread_->worker_task_runner(),

[DaleCurtis, 2016/12/02 18:20:13]

Do these need std::move() or does that happen automatically in this case? I'm
still unused to this new pass-by-value world :)

[Max Morin, 2016/12/02 20:37:43]

These are temporary variables, so they are already rvalues and don't need
std::move. I'll fix your comments on monday.

+        MediaInternals::GetInstance());
   }
   CHECK(audio_manager_);
 }
 
 }  // namespace content