Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2443573002: [compiler] Prepare for partially shipping Ignition. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
mvstanton, rmcilroy
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Prepare for partially shipping Ignition. This prepares the code-base so that Ignition can be enabled on a certain subset of compilations without setting the {FLAG_ignition} flag (which enables Ignition on all compilations). We should not check the flag in question explicitly anywhere outside of the compiler heuristics. R=mvstanton@chromium.org Committed: https://crrev.com/8549811ae3e67f1f7578aef7c3e1d8bbcf97105e Cr-Commit-Position: refs/heads/master@{#40617}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/frames.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/log.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 30 (16 generated)
Michael Starzinger
4 years, 2 months ago (2016-10-21 12:41:01 UTC) #3
Michael Starzinger
FYI, this is subset of: https://codereview.chromium.org/2427953002/
4 years, 2 months ago (2016-10-21 12:41:19 UTC) #4
mvstanton
Right on, rubber-stamp LGTM
4 years, 2 months ago (2016-10-21 13:04:04 UTC) #5
mvstanton
Right on, rubber-stamp LGTM
4 years, 2 months ago (2016-10-21 13:04:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443573002/1
4 years, 2 months ago (2016-10-21 13:11:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 13:14:20 UTC) #11
Michael Starzinger
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2448443002/ by mstarzinger@chromium.org. ...
4 years, 1 month ago (2016-10-24 12:33:41 UTC) #12
Michael Starzinger
Rebased onto 7db6c79acd6ccf45984275136e8c58c4be0f0fd9 which should addressed the performance regressions. Kudos go to Ross. Will reland ...
4 years, 1 month ago (2016-10-27 11:00:46 UTC) #17
rmcilroy
Uncomfortably excited :D.
4 years, 1 month ago (2016-10-27 11:13:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443573002/20001
4 years, 1 month ago (2016-10-27 12:15:07 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 12:17:20 UTC) #25
Michael Achenbach
Any chance that this makes arm64 sim debug nosnap much slower: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/2879
4 years, 1 month ago (2016-10-27 20:13:29 UTC) #26
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e31e5e91a51b4a645de8cc0f398d6ac728b1db5b Cr-Commit-Position: refs/heads/master@{#40507}
4 years, 1 month ago (2016-11-17 22:09:58 UTC) #28
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:15:22 UTC) #30
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8549811ae3e67f1f7578aef7c3e1d8bbcf97105e
Cr-Commit-Position: refs/heads/master@{#40617}

Powered by Google App Engine
This is Rietveld 408576698