Create correct GLES3 context for GLES3 unittest

gpu/command_buffer/service/test_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/test_helper.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 557 matching lines @@
     EXPECT_CALL(*gl, BindFramebufferEXT(GL_FRAMEBUFFER, fb_ids[1]))
         .Times(1)
         .RetiresOnSaturation();
     EXPECT_CALL(*gl, FramebufferTexture2DEXT(GL_FRAMEBUFFER,
         GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, tx_ids[1], 0))
         .Times(1)
         .RetiresOnSaturation();
     EXPECT_CALL(*gl, CheckFramebufferStatusEXT(GL_FRAMEBUFFER))
         .WillOnce(Return(GL_FRAMEBUFFER_COMPLETE))
         .RetiresOnSaturation();
+    GLenum status_rgba = GL_FRAMEBUFFER_COMPLETE;

[qiankun, 2016/10/21 10:51:04]

See the actual executed code here:
https://cs.chromium.org/chromium/src/gpu/command_buffer/service/feature_info....

     EXPECT_CALL(*gl, TexImage2D(GL_TEXTURE_2D, 0, GL_RGB32F, width, width, 0,
         GL_RGB, GL_FLOAT, _))
         .Times(1)
         .RetiresOnSaturation();
     if (gl_info.is_es3) {
       EXPECT_CALL(*gl, CheckFramebufferStatusEXT(GL_FRAMEBUFFER))
           .WillOnce(Return(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT))
           .RetiresOnSaturation();
     } else {
       EXPECT_CALL(*gl, CheckFramebufferStatusEXT(GL_FRAMEBUFFER))
           .WillOnce(Return(GL_FRAMEBUFFER_COMPLETE))
           .RetiresOnSaturation();
+    }
 
+    if (status_rgba == GL_FRAMEBUFFER_COMPLETE) {

[Zhenyao Mo, 2016/10/21 17:51:20]

I don't think I understand the motivation of this change.  We don't have code
path to modify |status_rgba| so this is always true. Then why do we need this?

[qiankun, 2016/10/22 11:47:13]

Yes, this always is true. I used it to align with the actual executed code, here
https://cs.chromium.org/chromium/src/gpu/command_buffer/service/feature_info.....

But previous code is wrong here because the following code is only executed when
gl_info.is_es3 == false (it's in the else branch of if statement at line 583).

[Zhenyao Mo, 2016/10/25 22:41:14]

I see. It's fine then.

       if (enable_es3 && gl_info.is_es3_capable) {
         EXPECT_CALL(*gl, TexImage2D(GL_TEXTURE_2D, 0, GL_R16F, width, width,
             0, GL_RED, GL_FLOAT, _))
             .Times(1)
             .RetiresOnSaturation();
         EXPECT_CALL(*gl, CheckFramebufferStatusEXT(GL_FRAMEBUFFER))
             .Times(1)
             .RetiresOnSaturation();
         EXPECT_CALL(*gl, TexImage2D(GL_TEXTURE_2D, 0, GL_RG16F, width, width,
             0, GL_RG, GL_FLOAT, _))
@@ skipping 601 matching lines @@
     GLenum precision,
     bool static_use,
     const std::string& name) {
   return ConstructShaderVariable<sh::OutputVariable>(
       type, array_size, precision, static_use, name);
 }
 
 }  // namespace gles2
 }  // namespace gpu