third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h - Issue 2443543002: createElement should not transmit exceptions but report them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

Issue 2443543002: createElement should not transmit exceptions but report them. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

index 125ce0cc64ba2d9d84f0ddde559f9ada57a9c625..4619356f9a0409cde370d224a56475631b372245 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

@@ -46,9 +46,6 @@ class CORE_EXPORT ScriptCustomElementDefinition final

v8::Local<v8::Object> prototype() const;

HTMLElement* createElementSync(Document&, const QualifiedName&) override;

- HTMLElement* createElementSync(Document&,

- const QualifiedName&,

- ExceptionState&) override;

bool hasConnectedCallback() const override;

bool hasDisconnectedCallback() const override;

@@ -86,6 +83,11 @@ class CORE_EXPORT ScriptCustomElementDefinition final

int argc = 0,

v8::Local<v8::Value> argv[] = nullptr);

+ HTMLElement* handleCreateElementSyncException(Document&,

+ const QualifiedName& tagName,

+ v8::Isolate*,

+ ExceptionState&);

RefPtr<ScriptState> m_scriptState;

ScopedPersistent<v8::Object> m_constructor;

ScopedPersistent<v8::Object> m_prototype;