Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(42)

Issue 2443513002: Reland of Mark layout test NeedsRebaseline (Closed)

Created:
2 years, 9 months ago by shimazu
Modified:
2 years, 9 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Mark layout test NeedsRebaseline My patch ( https://crrev.com/2415873002 ) overwrote a patch ( https://crrev.com/2428633003 ) by mistake, so this patch relands it. Original issue's description: > V8 change has landed, regenerate expected output now. > > V8 CL: https://codereview.chromium.org/2415073003. > Set NeedsManualRebaseline in https://codereview.chromium.org/2423113002. > > BUG=656622 > R=jochen@chromium.org, kozyatinskiy@chromium.org > > Review-Url: https://chromiumcodereview.appspot.com/2428633003 > Cr-Commit-Position: refs/heads/master@{#426193} BUG=656622 NOTRY=true Committed: https://crrev.com/8798e8897cf96b2aa478d821005ecfc282d1e60c Cr-Commit-Position: refs/heads/master@{#426746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
shimazu
Sorry for confusing... PTAL.
2 years, 9 months ago (2016-10-21 04:21:00 UTC) #2
Clemens Hammacher
lgtm
2 years, 9 months ago (2016-10-21 05:28:36 UTC) #3
Michael Achenbach
lgtm
2 years, 9 months ago (2016-10-21 06:58:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443513002/1
2 years, 9 months ago (2016-10-21 06:59:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 9 months ago (2016-10-21 07:17:14 UTC) #9
commit-bot: I haz the power
2 years, 9 months ago (2016-10-21 13:28:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8798e8897cf96b2aa478d821005ecfc282d1e60c
Cr-Commit-Position: refs/heads/master@{#426746}

Powered by Google App Engine
This is Rietveld 408576698