Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2443483003: Revert of Move Java CachedMetrics functionality to base/. (Closed)

Created:
4 years, 2 months ago by Dmitry Skiba
Modified:
4 years, 2 months ago
CC:
chromium-reviews, zpeng+watch_chromium.org, dominickn+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, lizeb+watch-custom-tabs_chromium.org, David Black, asvitkine+watch_chromium.org, agrieve+watch_chromium.org, kmadhusu+watch_chromium.org, jfweitz+watch_chromium.org, pkotwicz+watch_chromium.org, Jered, nyquist
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move Java CachedMetrics functionality to base/. (patchset #2 id:40001 of https://codereview.chromium.org/2435813002/ ) Reason for revert: broke Clank: ExternalAuthUtilsInternal depends on LaunchMetrics.TimesHistogramSample Original issue's description: > Move Java CachedMetrics functionality to base/. > > This is general-purpose functionality that allows > recording UMA metrics before the C++ native library > has been loaded and is useful to have outside of the > Chrome layer. In particular, I will be using it from > components/variations to record information about the > first run variations seed fetch. > > No functional changes in this CL. > > BUG=632199 TBR=bauerb@chromium.org,thestig@chromium.org,asvitkine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=632199 Committed: https://crrev.com/9590d9b4d5567c6c32fc8824df488eb5647709ba Cr-Commit-Position: refs/heads/master@{#426701}

Patch Set 1 #

Messages

Total messages: 14 (5 generated)
Dmitry Skiba
Created Revert of Move Java CachedMetrics functionality to base/.
4 years, 2 months ago (2016-10-21 02:16:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443483003/1
4 years, 2 months ago (2016-10-21 02:16:46 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-21 02:16:48 UTC) #5
Dmitry Skiba
On 2016/10/21 02:16:06, Dmitry Skiba wrote: > Created Revert of Move Java CachedMetrics functionality to ...
4 years, 2 months ago (2016-10-21 02:16:58 UTC) #6
Ted C
lgtm
4 years, 2 months ago (2016-10-21 02:38:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443483003/1
4 years, 2 months ago (2016-10-21 02:39:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 02:40:43 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9590d9b4d5567c6c32fc8824df488eb5647709ba Cr-Commit-Position: refs/heads/master@{#426701}
4 years, 2 months ago (2016-10-21 13:26:28 UTC) #13
Alexei Svitkine (slow)
4 years, 2 months ago (2016-10-21 20:14:01 UTC) #14
Message was sent while issue was closed.
Relanded as https://codereview.chromium.org/2439113002/

Powered by Google App Engine
This is Rietveld 408576698