third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h - Issue 2443473003: bluetooth: Require frame to be connected for characteristic.readValue to succeed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

Issue 2443473003: bluetooth: Require frame to be connected for characteristic.readValue to succeed (Closed)

Patch Set: Clean up Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-disconnects-before.js ('K') | « third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-disconnect-called-during-success.js ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

index a29f0fa10afa1fc87865d8eebaf7f64ea38e24f0..7e575f874a35606467f8b2cc686b0e0892626724 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

@@ -96,6 +96,10 @@ class BluetoothRemoteGATTCharacteristic final

RegisteredEventListener&) override;

private:

+ friend class ReadValueCallback;

+ BluetoothRemoteGATTServer* gatt() { return m_service->device()->gatt(); }

std::unique_ptr<WebBluetoothRemoteGATTCharacteristicInit> m_webCharacteristic;

Member<BluetoothRemoteGATTService> m_service;

bool m_stopped;