Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2443413002: Blacklist VirtualBox driver on linux (Closed)

Created:
4 years, 1 month ago by piman
Modified:
4 years, 1 month ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blacklist VirtualBox driver on linux BUG=656572, 658668 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/9154331c218d5917c7f27b9dedcc4d1cf884c7b8 Cr-Commit-Position: refs/heads/master@{#427208}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M gpu/config/software_rendering_list_json.cc View 2 chunks +14 lines, -1 line 1 comment Download

Messages

Total messages: 18 (10 generated)
piman
4 years, 1 month ago (2016-10-24 21:37:41 UTC) #5
Zhenyao Mo
lgtm https://codereview.chromium.org/2443413002/diff/1/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/2443413002/diff/1/gpu/config/software_rendering_list_json.cc#newcode1386 gpu/config/software_rendering_list_json.cc:1386: "device_id": ["0xbeef"], Is that their joke for this ...
4 years, 1 month ago (2016-10-24 21:38:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443413002/1
4 years, 1 month ago (2016-10-24 22:22:49 UTC) #10
piman
On 2016/10/24 21:38:36, Zhenyao Mo wrote: > lgtm > > https://codereview.chromium.org/2443413002/diff/1/gpu/config/software_rendering_list_json.cc > File gpu/config/software_rendering_list_json.cc (right): ...
4 years, 1 month ago (2016-10-24 22:22:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/151214)
4 years, 1 month ago (2016-10-24 23:22:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443413002/1
4 years, 1 month ago (2016-10-24 23:24:22 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 01:13:15 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 01:16:14 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9154331c218d5917c7f27b9dedcc4d1cf884c7b8
Cr-Commit-Position: refs/heads/master@{#427208}

Powered by Google App Engine
This is Rietveld 408576698