When unblocking a WebContents, don't bring it to the front if it is not already.

When unblocking a WebContents, don't bring it to the front if it is not already.

BUG=629964, 658772
Committed: https://crrev.com/713077b86adca2120992f5432afb2b58a1ff0909
Cr-Commit-Position: refs/heads/master@{#427776}

[Avi (use Gerrit), 2016-10-24 20:38:08]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 20:39:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 21:57:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 21:57:57]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-24 22:43:14]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-10-24 22:43:15]

It sound like the goal here it prevent tabs from stealing focus?

https://codereview.chromium.org/2443383002/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/2443383002/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:1909: if (!blocked && contents_is_active &&
browser_active)
Maybe return early if |blocked| is true?

[Avi (use Gerrit), 2016-10-25 03:01:51]

On 2016/10/24 22:43:15, Lei Zhang wrote:
> It sound like the goal here it prevent tabs from stealing focus?

Yes, if a tab in a background window loses a dialog, that shouldn't cause the
window to jump to the foreground.

[Lei Zhang, 2016-10-25 05:16:39]

On 2016/10/25 03:01:51, Avi wrote:
> On 2016/10/24 22:43:15, Lei Zhang wrote:
> > It sound like the goal here it prevent tabs from stealing focus?
> 
> Yes, if a tab in a background window loses a dialog, that shouldn't cause the
> window to jump to the foreground.

Makes sense. Did you want me to be the reviewer?

[Avi (use Gerrit), 2016-10-25 15:04:44]

On 2016/10/25 05:16:39, Lei Zhang wrote:
> On 2016/10/25 03:01:51, Avi wrote:
> > On 2016/10/24 22:43:15, Lei Zhang wrote:
> > > It sound like the goal here it prevent tabs from stealing focus?
> > 
> > Yes, if a tab in a background window loses a dialog, that shouldn't cause
the
> > window to jump to the foreground.
> 
> Makes sense. Did you want me to be the reviewer?

You're as qualified as anyone else :)

[Avi (use Gerrit), 2016-10-25 15:07:09]

https://codereview.chromium.org/2443383002/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/2443383002/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:1909: if (!blocked && contents_is_active &&
browser_active)
On 2016/10/24 22:43:15, Lei Zhang wrote:
> Maybe return early if |blocked| is true?

There are three conditions to focusing it; it feels weird to me to test just
one, unless you're worried about the cost of calculating the others, but how
often does this happen?

[Lei Zhang, 2016-10-25 17:31:43]

lgtm

https://codereview.chromium.org/2443383002/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/2443383002/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:1909: if (!blocked && contents_is_active &&
browser_active)
On 2016/10/25 15:07:08, Avi wrote:
> On 2016/10/24 22:43:15, Lei Zhang wrote:
> > Maybe return early if |blocked| is true?
> 
> There are three conditions to focusing it; it feels weird to me to test just
> one, unless you're worried about the cost of calculating the others, but how
> often does this happen?

I'm not that worried about it. I just saw it from the "it already failed, why
keep going" perspective.

[Avi (use Gerrit), 2016-10-26 18:19:54]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-10-26 18:20:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 19:44:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-26 20:00:13]

Description was changed from

==========
When unblocking a WebContents, don't bring it to the front if it is not already.

BUG=629964, 658772
==========

to

==========
When unblocking a WebContents, don't bring it to the front if it is not already.

BUG=629964, 658772

Committed: https://crrev.com/713077b86adca2120992f5432afb2b58a1ff0909
Cr-Commit-Position: refs/heads/master@{#427776}
==========

[commit-bot: I haz the power, 2016-10-26 20:00:14]

Patchset 1 (id:??) landed as
https://crrev.com/713077b86adca2120992f5432afb2b58a1ff0909
Cr-Commit-Position: refs/heads/master@{#427776}