Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/BUILD.gn

Issue 2443373002: Split //ios/chrome/browser in multiple targets. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/app/application_delegate/BUILD.gn ('k') | ios/chrome/browser/autocomplete/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/BUILD.gn
diff --git a/ios/chrome/browser/BUILD.gn b/ios/chrome/browser/BUILD.gn
index 00de54058ba5eb85f44a9f93b43cf7b1a93bacf8..b9f791642b236badd47ad37de4db233b269f2ee7 100644
--- a/ios/chrome/browser/BUILD.gn
+++ b/ios/chrome/browser/BUILD.gn
@@ -19,90 +19,91 @@ declare_args() {
google_test_sync_url = ""
}
-source_set("browser") {
+# TODO(crbug.com/658242): this target is there to avoid breaking downstream
+# when this CL rolls. It should be removed in favor of browser_no_public_deps
+# (which should be renamed to browser).
+group("browser") {
+ public_deps = [
+ ":browser_no_public_deps",
+ "//ios/chrome/browser:browser_impl",
+ "//ios/chrome/browser/autocomplete",
+ "//ios/chrome/browser/autofill",
+ "//ios/chrome/browser/bookmarks",
+ "//ios/chrome/browser/bookmarks:bookmarks_utils",
+ "//ios/chrome/browser/browser_state",
+ "//ios/chrome/browser/browser_state:browser_state_impl",
+ "//ios/chrome/browser/browser_state_metrics",
+ "//ios/chrome/browser/browsing_data",
+ "//ios/chrome/browser/component_updater",
+ "//ios/chrome/browser/content_settings",
+ "//ios/chrome/browser/crash_report",
+ "//ios/chrome/browser/dom_distiller",
+ "//ios/chrome/browser/favicon",
+ "//ios/chrome/browser/find_in_page",
+ "//ios/chrome/browser/first_run",
+ "//ios/chrome/browser/geolocation",
+ "//ios/chrome/browser/google",
+ "//ios/chrome/browser/google:google_logo",
+ "//ios/chrome/browser/history",
+ "//ios/chrome/browser/infobars",
+ "//ios/chrome/browser/interstitials",
+ "//ios/chrome/browser/invalidation",
+ "//ios/chrome/browser/itunes_links",
+ "//ios/chrome/browser/memory",
+ "//ios/chrome/browser/metrics",
+ "//ios/chrome/browser/net",
+ "//ios/chrome/browser/ntp_snippets",
+ "//ios/chrome/browser/ntp_tiles",
+ "//ios/chrome/browser/open_from_clipboard",
+ "//ios/chrome/browser/passwords",
+ "//ios/chrome/browser/physical_web",
+ "//ios/chrome/browser/prefs",
+ "//ios/chrome/browser/reading_list",
+ "//ios/chrome/browser/search_engines",
+ "//ios/chrome/browser/services/gcm",
+ "//ios/chrome/browser/sessions",
+ "//ios/chrome/browser/share_extension",
+ "//ios/chrome/browser/snapshots",
+ "//ios/chrome/browser/ssl",
+ "//ios/chrome/browser/suggestions",
+ "//ios/chrome/browser/sync",
+ "//ios/chrome/browser/sync/glue",
+ "//ios/chrome/browser/sync/sessions",
+ "//ios/chrome/browser/translate",
+ "//ios/chrome/browser/ui",
+ "//ios/chrome/browser/ui/alert_coordinator",
+ "//ios/chrome/browser/ui/autofill",
+ "//ios/chrome/browser/ui/commands",
+ "//ios/chrome/browser/ui/context_menu",
+ "//ios/chrome/browser/ui/elements",
+ "//ios/chrome/browser/ui/keyboard",
+ "//ios/chrome/browser/ui/webui",
+ "//ios/chrome/browser/ui/webui/gcm",
+ "//ios/chrome/browser/ui/webui/history",
+ "//ios/chrome/browser/ui/webui/net_export",
+ "//ios/chrome/browser/ui/webui/sync_internals",
+ "//ios/chrome/browser/undo",
+ "//ios/chrome/browser/updatable_config",
+ "//ios/chrome/browser/update_client",
+ "//ios/chrome/browser/variations",
+ "//ios/chrome/browser/web",
+ "//ios/chrome/browser/web_resource",
+ "//ios/chrome/browser/webp_transcode",
+ ]
+}
+
+# TODO(crbug.com/658242): this target is there to avoid breaking downstream
+# when this CL rolls. It should renamed to browser.
+source_set("browser_no_public_deps") {
sources = [
"app_startup_parameters.h",
"app_startup_parameters.mm",
"application_context.cc",
"application_context.h",
- "application_context_impl.cc",
- "application_context_impl.h",
"arch_util.cc",
"arch_util.h",
- "autocomplete/autocomplete_classifier_factory.cc",
- "autocomplete/autocomplete_classifier_factory.h",
- "autocomplete/autocomplete_provider_client_impl.cc",
- "autocomplete/autocomplete_provider_client_impl.h",
- "autocomplete/autocomplete_scheme_classifier_impl.h",
- "autocomplete/autocomplete_scheme_classifier_impl.mm",
- "autocomplete/in_memory_url_index_factory.cc",
- "autocomplete/in_memory_url_index_factory.h",
- "autocomplete/shortcuts_backend_factory.h",
- "autocomplete/shortcuts_backend_factory.mm",
- "autofill/form_input_accessory_view.h",
- "autofill/form_input_accessory_view.mm",
- "autofill/form_input_accessory_view_controller.h",
- "autofill/form_input_accessory_view_controller.mm",
- "autofill/form_input_accessory_view_delegate.h",
- "autofill/form_suggestion_controller.h",
- "autofill/form_suggestion_controller.mm",
- "autofill/form_suggestion_label.h",
- "autofill/form_suggestion_label.mm",
- "autofill/form_suggestion_provider.h",
- "autofill/form_suggestion_view.h",
- "autofill/form_suggestion_view.mm",
- "autofill/form_suggestion_view_client.h",
- "autofill/personal_data_manager_factory.cc",
- "autofill/personal_data_manager_factory.h",
- "bookmarks/bookmark_client_impl.cc",
- "bookmarks/bookmark_client_impl.h",
- "bookmarks/bookmark_model_factory.cc",
- "bookmarks/bookmark_model_factory.h",
- "bookmarks/bookmarks_utils.cc",
- "bookmarks/bookmarks_utils.h",
- "bookmarks/startup_task_runner_service_factory.cc",
- "bookmarks/startup_task_runner_service_factory.h",
"browser_about_rewriter.cc",
"browser_about_rewriter.h",
- "browser_state/bookmark_model_loaded_observer.cc",
- "browser_state/bookmark_model_loaded_observer.h",
- "browser_state/browser_state_info_cache.cc",
- "browser_state/browser_state_info_cache.h",
- "browser_state/browser_state_info_cache_observer.h",
- "browser_state/browser_state_keyed_service_factories.h",
- "browser_state/browser_state_keyed_service_factories.mm",
- "browser_state/browser_state_otr_helper.cc",
- "browser_state/browser_state_otr_helper.h",
- "browser_state/chrome_browser_state.h",
- "browser_state/chrome_browser_state.mm",
- "browser_state/chrome_browser_state_impl.cc",
- "browser_state/chrome_browser_state_impl.h",
- "browser_state/chrome_browser_state_impl_io_data.h",
- "browser_state/chrome_browser_state_impl_io_data.mm",
- "browser_state/chrome_browser_state_io_data.cc",
- "browser_state/chrome_browser_state_io_data.h",
- "browser_state/chrome_browser_state_manager.h",
- "browser_state/chrome_browser_state_manager_impl.cc",
- "browser_state/chrome_browser_state_manager_impl.h",
- "browser_state/chrome_browser_state_removal_controller.h",
- "browser_state/chrome_browser_state_removal_controller.mm",
- "browser_state/off_the_record_chrome_browser_state_impl.cc",
- "browser_state/off_the_record_chrome_browser_state_impl.h",
- "browser_state/off_the_record_chrome_browser_state_io_data.h",
- "browser_state/off_the_record_chrome_browser_state_io_data.mm",
- "browser_state_metrics/browser_state_metrics.cc",
- "browser_state_metrics/browser_state_metrics.h",
- "browsing_data/browsing_data_change_listening.h",
- "browsing_data/browsing_data_counter_wrapper.cc",
- "browsing_data/browsing_data_counter_wrapper.h",
- "browsing_data/browsing_data_remover_helper.cc",
- "browsing_data/browsing_data_remover_helper.h",
- "browsing_data/cache_counter.cc",
- "browsing_data/cache_counter.h",
- "browsing_data/ios_browsing_data_counter_factory.cc",
- "browsing_data/ios_browsing_data_counter_factory.h",
- "browsing_data/ios_chrome_browsing_data_remover.h",
- "browsing_data/ios_chrome_browsing_data_remover.mm",
"chrome_constants.cc",
"chrome_constants.h",
"chrome_coordinator.h",
@@ -116,621 +117,130 @@ source_set("browser") {
"chrome_url_constants.h",
"chrome_url_util.h",
"chrome_url_util.mm",
- "component_updater/ios_component_updater_configurator.cc",
- "component_updater/ios_component_updater_configurator.h",
- "content_settings/cookie_settings_factory.cc",
- "content_settings/cookie_settings_factory.h",
- "content_settings/host_content_settings_map_factory.cc",
- "content_settings/host_content_settings_map_factory.h",
"crash_loop_detection_util.h",
"crash_loop_detection_util.mm",
- "crash_report/breakpad_helper.h",
- "crash_report/breakpad_helper.mm",
- "crash_report/crash_keys.cc",
- "crash_report/crash_keys.h",
- "crash_report/crash_report_background_uploader.h",
- "crash_report/crash_report_background_uploader.mm",
- "crash_report/crash_report_multi_parameter.h",
- "crash_report/crash_report_multi_parameter.mm",
- "crash_report/crash_report_user_application_state.h",
- "crash_report/crash_report_user_application_state.mm",
- "crash_report/crash_upload_list.cc",
- "crash_report/crash_upload_list.h",
- "dom_distiller/distiller_viewer.cc",
- "dom_distiller/distiller_viewer.h",
- "dom_distiller/dom_distiller_service_factory.cc",
- "dom_distiller/dom_distiller_service_factory.h",
"experimental_flags.h",
"experimental_flags.mm",
- "favicon/favicon_attributes.h",
- "favicon/favicon_attributes.mm",
- "favicon/favicon_attributes_provider.h",
- "favicon/favicon_attributes_provider.mm",
- "favicon/favicon_client_impl.h",
- "favicon/favicon_client_impl.mm",
- "favicon/favicon_loader.h",
- "favicon/favicon_loader.mm",
- "favicon/favicon_service_factory.cc",
- "favicon/favicon_service_factory.h",
- "favicon/ios_chrome_favicon_loader_factory.h",
- "favicon/ios_chrome_favicon_loader_factory.mm",
- "favicon/ios_chrome_large_icon_cache_factory.cc",
- "favicon/ios_chrome_large_icon_cache_factory.h",
- "favicon/ios_chrome_large_icon_service_factory.cc",
- "favicon/ios_chrome_large_icon_service_factory.h",
- "favicon/large_icon_cache.cc",
- "favicon/large_icon_cache.h",
"file_metadata_util.h",
"file_metadata_util.mm",
- "find_in_page/find_in_page_controller.h",
- "find_in_page/find_in_page_controller.mm",
- "find_in_page/find_in_page_model.h",
- "find_in_page/find_in_page_model.mm",
- "find_in_page/js_findinpage_manager.h",
- "find_in_page/js_findinpage_manager.mm",
- "first_run/first_run.h",
- "first_run/first_run.mm",
- "first_run/first_run_configuration.h",
- "first_run/first_run_configuration.mm",
- "first_run/first_run_metrics.h",
- "geolocation/CLLocation+OmniboxGeolocation.h",
- "geolocation/CLLocation+OmniboxGeolocation.mm",
- "geolocation/CLLocation+XGeoHeader.h",
- "geolocation/CLLocation+XGeoHeader.mm",
- "geolocation/location_manager+Testing.h",
- "geolocation/location_manager.h",
- "geolocation/location_manager.mm",
- "geolocation/omnibox_geolocation_authorization_alert.h",
- "geolocation/omnibox_geolocation_authorization_alert.mm",
- "geolocation/omnibox_geolocation_config.h",
- "geolocation/omnibox_geolocation_config.mm",
- "geolocation/omnibox_geolocation_local_state.h",
- "geolocation/omnibox_geolocation_local_state.mm",
- "google/google_brand.h",
- "google/google_brand.mm",
- "google/google_logo_service.h",
- "google/google_logo_service.mm",
- "google/google_logo_service_factory.h",
- "google/google_logo_service_factory.mm",
- "google/google_url_tracker_client_impl.cc",
- "google/google_url_tracker_client_impl.h",
- "google/google_url_tracker_factory.cc",
- "google/google_url_tracker_factory.h",
- "history/history_backend_client_impl.cc",
- "history/history_backend_client_impl.h",
- "history/history_client_impl.cc",
- "history/history_client_impl.h",
- "history/history_service_factory.cc",
- "history/history_service_factory.h",
- "history/history_utils.cc",
- "history/history_utils.h",
- "history/top_sites_factory.cc",
- "history/top_sites_factory.h",
- "history/web_history_service_factory.cc",
- "history/web_history_service_factory.h",
- "infobars/confirm_infobar_controller+protected.h",
- "infobars/confirm_infobar_controller.h",
- "infobars/confirm_infobar_controller.mm",
- "infobars/infobar.h",
- "infobars/infobar.mm",
- "infobars/infobar_container_ios.h",
- "infobars/infobar_container_ios.mm",
- "infobars/infobar_container_view.h",
- "infobars/infobar_container_view.mm",
- "infobars/infobar_controller.h",
- "infobars/infobar_controller.mm",
- "infobars/infobar_manager_impl.h",
- "infobars/infobar_manager_impl.mm",
- "infobars/infobar_utils.h",
- "infobars/infobar_utils.mm",
"install_time_util.h",
"install_time_util.mm",
"installation_notifier.h",
"installation_notifier.mm",
- "interstitials/ios_chrome_controller_client.h",
- "interstitials/ios_chrome_controller_client.mm",
- "interstitials/ios_chrome_metrics_helper.h",
- "interstitials/ios_chrome_metrics_helper.mm",
- "interstitials/ios_security_interstitial_page.h",
- "interstitials/ios_security_interstitial_page.mm",
- "invalidation/ios_chrome_profile_invalidation_provider_factory.h",
- "invalidation/ios_chrome_profile_invalidation_provider_factory.mm",
"ios_chrome_field_trials.cc",
"ios_chrome_field_trials.h",
"ios_chrome_io_thread.h",
"ios_chrome_io_thread.mm",
- "ios_chrome_main_parts.h",
- "ios_chrome_main_parts.mm",
- "itunes_links/itunes_links_observer.h",
- "itunes_links/itunes_links_observer.mm",
- "memory/memory_debugger.h",
- "memory/memory_debugger.mm",
- "memory/memory_debugger_manager.h",
- "memory/memory_debugger_manager.mm",
- "memory/memory_metrics.cc",
- "memory/memory_metrics.h",
- "metrics/field_trial_synchronizer.cc",
- "metrics/field_trial_synchronizer.h",
- "metrics/ios_chrome_metrics_service_accessor.cc",
- "metrics/ios_chrome_metrics_service_accessor.h",
- "metrics/ios_chrome_metrics_service_client.cc",
- "metrics/ios_chrome_metrics_service_client.h",
- "metrics/ios_chrome_metrics_services_manager_client.h",
- "metrics/ios_chrome_metrics_services_manager_client.mm",
- "metrics/ios_chrome_origins_seen_service_factory.cc",
- "metrics/ios_chrome_origins_seen_service_factory.h",
- "metrics/ios_chrome_stability_metrics_provider.cc",
- "metrics/ios_chrome_stability_metrics_provider.h",
- "metrics/mobile_session_shutdown_metrics_provider.h",
- "metrics/mobile_session_shutdown_metrics_provider.mm",
- "metrics/previous_session_info.h",
- "metrics/previous_session_info.mm",
- "metrics/previous_session_info_private.h",
- "net/chrome_cookie_store_ios_client.h",
- "net/chrome_cookie_store_ios_client.mm",
- "net/connection_type_observer_bridge.h",
- "net/connection_type_observer_bridge.mm",
- "net/cookie_util.h",
- "net/cookie_util.mm",
- "net/crl_set_fetcher.cc",
- "net/crl_set_fetcher.h",
- "net/http_server_properties_manager_factory.cc",
- "net/http_server_properties_manager_factory.h",
- "net/image_fetcher.h",
- "net/image_fetcher.mm",
- "net/ios_chrome_http_user_agent_settings.h",
- "net/ios_chrome_http_user_agent_settings.mm",
- "net/ios_chrome_network_delegate.cc",
- "net/ios_chrome_network_delegate.h",
- "net/ios_chrome_url_request_context_getter.cc",
- "net/ios_chrome_url_request_context_getter.h",
- "net/metrics_network_client.h",
- "net/metrics_network_client.mm",
- "net/metrics_network_client_manager.h",
- "net/metrics_network_client_manager.mm",
- "net/net_types.h",
- "net/proxy_service_factory.cc",
- "net/proxy_service_factory.h",
- "net/retryable_url_fetcher.h",
- "net/retryable_url_fetcher.mm",
"notification_promo.cc",
"notification_promo.h",
- "ntp_snippets/ios_chrome_content_suggestions_service_factory.cc",
- "ntp_snippets/ios_chrome_content_suggestions_service_factory.h",
- "ntp_tiles/ios_most_visited_sites_factory.cc",
- "ntp_tiles/ios_most_visited_sites_factory.h",
- "ntp_tiles/ios_popular_sites_factory.cc",
- "ntp_tiles/ios_popular_sites_factory.h",
- "open_from_clipboard/create_clipboard_recent_content.h",
- "open_from_clipboard/create_clipboard_recent_content.mm",
"open_url_util.h",
"open_url_util.mm",
- "passwords/credential_manager.h",
- "passwords/credential_manager.mm",
- "passwords/ios_chrome_password_manager_client.h",
- "passwords/ios_chrome_password_manager_client.mm",
- "passwords/ios_chrome_password_manager_driver.h",
- "passwords/ios_chrome_password_manager_driver.mm",
- "passwords/ios_chrome_password_manager_infobar_delegate.h",
- "passwords/ios_chrome_password_manager_infobar_delegate.mm",
- "passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc",
- "passwords/ios_chrome_password_manager_setting_migrator_service_factory.h",
- "passwords/ios_chrome_password_store_factory.cc",
- "passwords/ios_chrome_password_store_factory.h",
- "passwords/ios_chrome_save_password_infobar_delegate.h",
- "passwords/ios_chrome_save_password_infobar_delegate.mm",
- "passwords/ios_chrome_update_password_infobar_delegate.h",
- "passwords/ios_chrome_update_password_infobar_delegate.mm",
- "passwords/js_credential_manager.h",
- "passwords/js_credential_manager.mm",
- "passwords/js_password_manager.h",
- "passwords/js_password_manager.mm",
- "passwords/password_controller.h",
- "passwords/password_controller.mm",
- "passwords/password_generation_agent.h",
- "passwords/password_generation_agent.mm",
- "passwords/password_generation_edit_view.h",
- "passwords/password_generation_edit_view.mm",
- "passwords/password_generation_offer_view.h",
- "passwords/password_generation_offer_view.mm",
- "passwords/password_generation_prompt_delegate.h",
- "passwords/password_generation_utils.h",
- "passwords/password_generation_utils.mm",
- "passwords/passwords_ui_delegate.h",
- "passwords/update_password_infobar_controller.h",
- "passwords/update_password_infobar_controller.mm",
- "physical_web/create_physical_web_data_source.h",
- "physical_web/create_physical_web_data_source.mm",
- "physical_web/physical_web_constants.h",
- "physical_web/start_physical_web_discovery.h",
- "physical_web/start_physical_web_discovery.mm",
"pref_names.cc",
"pref_names.h",
- "prefs/browser_prefs.h",
- "prefs/browser_prefs.mm",
- "prefs/ios_chrome_pref_model_associator_client.cc",
- "prefs/ios_chrome_pref_model_associator_client.h",
- "prefs/ios_chrome_pref_service_factory.cc",
- "prefs/ios_chrome_pref_service_factory.h",
- "prefs/pref_observer_bridge.h",
- "prefs/pref_observer_bridge.mm",
"procedural_block_types.h",
- "reading_list/reading_list_download_service.cc",
- "reading_list/reading_list_download_service.h",
- "reading_list/reading_list_download_service_factory.cc",
- "reading_list/reading_list_download_service_factory.h",
- "reading_list/reading_list_entry.cc",
- "reading_list/reading_list_entry.h",
- "reading_list/reading_list_model.cc",
- "reading_list/reading_list_model.h",
- "reading_list/reading_list_model_bridge_observer.h",
- "reading_list/reading_list_model_bridge_observer.mm",
- "reading_list/reading_list_model_factory.cc",
- "reading_list/reading_list_model_factory.h",
- "reading_list/reading_list_model_impl.cc",
- "reading_list/reading_list_model_impl.h",
- "reading_list/reading_list_model_observer.h",
- "reading_list/reading_list_model_storage.h",
- "reading_list/reading_list_model_storage_defaults.h",
- "reading_list/reading_list_model_storage_defaults.mm",
- "reading_list/url_downloader.cc",
- "reading_list/url_downloader.h",
"root_coordinator.h",
"root_coordinator.mm",
- "search_engines/search_engines_util.cc",
- "search_engines/search_engines_util.h",
- "search_engines/template_url_service_client_impl.cc",
- "search_engines/template_url_service_client_impl.h",
- "search_engines/template_url_service_factory.cc",
- "search_engines/template_url_service_factory.h",
- "search_engines/ui_thread_search_terms_data.cc",
- "search_engines/ui_thread_search_terms_data.h",
- "services/gcm/ios_chrome_gcm_profile_service_factory.cc",
- "services/gcm/ios_chrome_gcm_profile_service_factory.h",
- "sessions/ios_chrome_session_tab_helper.h",
- "sessions/ios_chrome_session_tab_helper.mm",
- "sessions/ios_chrome_tab_restore_service_client.h",
- "sessions/ios_chrome_tab_restore_service_client.mm",
- "sessions/ios_chrome_tab_restore_service_factory.cc",
- "sessions/ios_chrome_tab_restore_service_factory.h",
- "share_extension/share_extension_item_receiver.h",
- "share_extension/share_extension_item_receiver.mm",
- "share_extension/share_extension_service.h",
- "share_extension/share_extension_service.mm",
- "share_extension/share_extension_service_factory.cc",
- "share_extension/share_extension_service_factory.h",
- "snapshots/lru_cache.h",
- "snapshots/lru_cache.mm",
- "snapshots/snapshot_cache.h",
- "snapshots/snapshot_cache.mm",
- "snapshots/snapshot_cache_internal.h",
- "snapshots/snapshot_manager.h",
- "snapshots/snapshot_manager.mm",
- "snapshots/snapshot_overlay.h",
- "snapshots/snapshot_overlay.mm",
- "snapshots/snapshots_util.h",
- "snapshots/snapshots_util.mm",
- "ssl/ios_chrome_security_state_model_client.h",
- "ssl/ios_chrome_security_state_model_client.mm",
- "ssl/ios_ssl_blocking_page.h",
- "ssl/ios_ssl_blocking_page.mm",
- "ssl/ios_ssl_error_handler.h",
- "ssl/ios_ssl_error_handler.mm",
"storekit_launcher.h",
- "suggestions/image_fetcher_impl.h",
- "suggestions/image_fetcher_impl.mm",
- "suggestions/ios_image_decoder_impl.h",
- "suggestions/ios_image_decoder_impl.mm",
- "suggestions/suggestions_service_factory.h",
- "suggestions/suggestions_service_factory.mm",
- "sync/glue/sync_start_util.cc",
- "sync/glue/sync_start_util.h",
- "sync/ios_chrome_profile_sync_service_factory.cc",
- "sync/ios_chrome_profile_sync_service_factory.h",
- "sync/ios_chrome_sync_client.h",
- "sync/ios_chrome_sync_client.mm",
- "sync/ios_chrome_synced_tab_delegate.h",
- "sync/ios_chrome_synced_tab_delegate.mm",
- "sync/sessions/ios_chrome_local_session_event_router.h",
- "sync/sessions/ios_chrome_local_session_event_router.mm",
- "sync/sync_observer_bridge.h",
- "sync/sync_observer_bridge.mm",
- "sync/sync_setup_service.cc",
- "sync/sync_setup_service.h",
- "sync/sync_setup_service_factory.cc",
- "sync/sync_setup_service_factory.h",
"tab_parenting_global_observer.cc",
"tab_parenting_global_observer.h",
- "translate/after_translate_infobar_controller.h",
- "translate/after_translate_infobar_controller.mm",
- "translate/before_translate_infobar_controller.h",
- "translate/before_translate_infobar_controller.mm",
- "translate/chrome_ios_translate_client.h",
- "translate/chrome_ios_translate_client.mm",
- "translate/never_translate_infobar_controller.h",
- "translate/never_translate_infobar_controller.mm",
- "translate/translate_accept_languages_factory.cc",
- "translate/translate_accept_languages_factory.h",
- "translate/translate_infobar_tags.h",
- "translate/translate_message_infobar_controller.h",
- "translate/translate_message_infobar_controller.mm",
- "translate/translate_service_ios.cc",
- "translate/translate_service_ios.h",
- "ui/UIView+SizeClassSupport.h",
- "ui/UIView+SizeClassSupport.mm",
- "ui/alert_coordinator/action_sheet_coordinator.h",
- "ui/alert_coordinator/action_sheet_coordinator.mm",
- "ui/alert_coordinator/alert_coordinator.h",
- "ui/alert_coordinator/alert_coordinator.mm",
- "ui/alert_coordinator/input_alert_coordinator.h",
- "ui/alert_coordinator/input_alert_coordinator.mm",
- "ui/animation_util.h",
- "ui/animation_util.mm",
- "ui/autofill/autofill_client_ios.h",
- "ui/autofill/autofill_client_ios.mm",
- "ui/autofill/autofill_save_card_infobar.mm",
- "ui/background_generator.h",
- "ui/background_generator.mm",
- "ui/browser_otr_state.h",
- "ui/browser_otr_state.mm",
- "ui/commands/UIKit+ChromeExecuteCommand.h",
- "ui/commands/UIKit+ChromeExecuteCommand.mm",
- "ui/commands/clear_browsing_data_command.h",
- "ui/commands/clear_browsing_data_command.mm",
- "ui/commands/generic_chrome_command.h",
- "ui/commands/generic_chrome_command.mm",
- "ui/commands/ios_command_ids.h",
- "ui/commands/open_url_command.h",
- "ui/commands/open_url_command.mm",
- "ui/commands/reading_list_add_command.h",
- "ui/commands/reading_list_add_command.mm",
- "ui/commands/set_up_for_testing_command.h",
- "ui/commands/set_up_for_testing_command.mm",
- "ui/commands/show_mail_composer_command.h",
- "ui/commands/show_mail_composer_command.mm",
- "ui/commands/show_signin_command.h",
- "ui/commands/show_signin_command.mm",
- "ui/context_menu/context_menu_coordinator.h",
- "ui/context_menu/context_menu_coordinator.mm",
- "ui/elements/selector_coordinator.h",
- "ui/elements/selector_coordinator.mm",
- "ui/elements/selector_picker_presentation_controller.h",
- "ui/elements/selector_picker_presentation_controller.mm",
- "ui/elements/selector_picker_view_controller.h",
- "ui/elements/selector_picker_view_controller.mm",
- "ui/elements/selector_view_controller_delegate.h",
- "ui/favicon_view.h",
- "ui/favicon_view.mm",
- "ui/file_locations.h",
- "ui/file_locations.mm",
- "ui/image_util.h",
- "ui/image_util.mm",
- "ui/keyboard/UIKeyCommand+Chrome.h",
- "ui/keyboard/UIKeyCommand+Chrome.mm",
- "ui/keyboard/hardware_keyboard_watcher.h",
- "ui/keyboard/hardware_keyboard_watcher.mm",
- "ui/native_content_controller.h",
- "ui/native_content_controller.mm",
- "ui/orientation_limiting_navigation_controller.h",
- "ui/orientation_limiting_navigation_controller.mm",
- "ui/prerender_final_status.h",
- "ui/reversed_animation.h",
- "ui/reversed_animation.mm",
- "ui/rtl_geometry.h",
- "ui/rtl_geometry.mm",
- "ui/show_mail_composer_util.h",
- "ui/show_mail_composer_util.mm",
- "ui/show_privacy_settings_util.h",
- "ui/show_privacy_settings_util.mm",
- "ui/side_swipe_gesture_recognizer.h",
- "ui/side_swipe_gesture_recognizer.mm",
- "ui/ui_util.h",
- "ui/ui_util.mm",
- "ui/uikit_ui_util.h",
- "ui/uikit_ui_util.mm",
- "ui/url_loader.h",
- "ui/webui/about_ui.cc",
- "ui/webui/about_ui.h",
- "ui/webui/crashes_ui.cc",
- "ui/webui/crashes_ui.h",
- "ui/webui/flags_ui.cc",
- "ui/webui/flags_ui.h",
- "ui/webui/gcm/gcm_internals_ui.cc",
- "ui/webui/gcm/gcm_internals_ui.h",
- "ui/webui/history/browsing_history_handler.cc",
- "ui/webui/history/browsing_history_handler.h",
- "ui/webui/history/favicon_source.cc",
- "ui/webui/history/favicon_source.h",
- "ui/webui/history/history_ui.h",
- "ui/webui/history/history_ui.mm",
- "ui/webui/history/metrics_handler.cc",
- "ui/webui/history/metrics_handler.h",
- "ui/webui/mojo_web_ui_ios_controller.h",
- "ui/webui/net_export/net_export_ui.cc",
- "ui/webui/net_export/net_export_ui.h",
- "ui/webui/physical_web_ui.cc",
- "ui/webui/physical_web_ui.h",
- "ui/webui/sync_internals/sync_internals_message_handler.cc",
- "ui/webui/sync_internals/sync_internals_message_handler.h",
- "ui/webui/sync_internals/sync_internals_ui.cc",
- "ui/webui/sync_internals/sync_internals_ui.h",
- "ui/webui/version_handler.cc",
- "ui/webui/version_handler.h",
- "ui/webui/version_ui.h",
- "ui/webui/version_ui.mm",
- "undo/bookmark_undo_service_factory.cc",
- "undo/bookmark_undo_service_factory.h",
- "updatable_config/updatable_array.h",
- "updatable_config/updatable_array.mm",
- "updatable_config/updatable_config_base.h",
- "updatable_config/updatable_config_base.mm",
- "updatable_config/updatable_dictionary.h",
- "updatable_config/updatable_dictionary.mm",
- "update_client/ios_chrome_update_query_params_delegate.cc",
- "update_client/ios_chrome_update_query_params_delegate.h",
- "variations/ios_chrome_variations_service_client.cc",
- "variations/ios_chrome_variations_service_client.h",
- "web/dom_altering_lock.h",
- "web/dom_altering_lock.mm",
- "web/resubmit_data_controller.h",
- "web/resubmit_data_controller.mm",
"web_data_service_factory.cc",
"web_data_service_factory.h",
- "web_resource/web_resource_util.cc",
- "web_resource/web_resource_util.h",
- "webp_transcode/webp_decoder.h",
- "webp_transcode/webp_decoder.mm",
"xcallback_parameters.h",
"xcallback_parameters.mm",
]
-
deps = [
- ":about_flags",
- ":injected_js",
"//base",
- "//base:i18n",
- "//breakpad:client",
- "//components/about_handler",
"//components/autofill/core/browser",
"//components/autofill/core/common",
- "//components/autofill/ios/browser",
- "//components/bookmarks/browser",
- "//components/browser_sync",
- "//components/browsing_data/core",
- "//components/component_updater",
- "//components/content_settings/core/browser",
- "//components/content_settings/core/common",
- "//components/cookie_config",
- "//components/crash/core/browser",
- "//components/crash/core/common",
- "//components/dom_distiller/core",
- "//components/dom_distiller/ios",
- "//components/favicon/core",
- "//components/favicon_base",
- "//components/flags_ui",
"//components/gcm_driver",
- "//components/google/core/browser",
- "//components/history/core/browser",
- "//components/history/ios/browser",
- "//components/image_fetcher",
- "//components/infobars/core",
- "//components/invalidation/impl",
- "//components/invalidation/public",
"//components/keyed_service/core",
"//components/keyed_service/ios",
- "//components/language_usage_metrics",
- "//components/leveldb_proto",
"//components/metrics",
- "//components/metrics:net",
- "//components/metrics:profiler",
- "//components/metrics:profiler_ios",
- "//components/metrics:ui",
"//components/metrics_services_manager",
- "//components/navigation_metrics",
"//components/net_log",
"//components/network_session_configurator",
- "//components/network_time",
- "//components/ntp_snippets",
- "//components/ntp_tiles",
- "//components/omnibox/browser",
- "//components/open_from_clipboard",
- "//components/password_manager/core/browser",
- "//components/password_manager/core/common",
- "//components/password_manager/sync/browser",
- "//components/physical_web/data_source",
- "//components/physical_web/webui",
- "//components/policy/core/common",
"//components/pref_registry",
"//components/prefs",
- "//components/profile_metrics",
"//components/proxy_config",
- "//components/rappor",
- "//components/resources",
- "//components/search",
"//components/search_engines",
- "//components/search_provider_logos",
- "//components/security_interstitials/core",
- "//components/security_state",
- "//components/sessions",
"//components/signin/core/browser",
- "//components/signin/core/common",
- "//components/signin/ios/browser",
"//components/ssl_config",
- "//components/strings",
- "//components/suggestions",
- "//components/sync",
- "//components/sync_sessions",
- "//components/syncable_prefs",
"//components/translate/core/browser",
- "//components/translate/core/common",
- "//components/translate/ios/browser",
- "//components/undo",
- "//components/update_client",
- "//components/upload_list",
"//components/url_formatter",
- "//components/user_prefs",
"//components/variations",
"//components/variations/service",
"//components/version_info",
- "//components/version_ui",
- "//components/web_resource",
"//components/webdata_services",
- "//google_apis",
- "//ios/chrome/browser/signin",
- "//ios/chrome/browser/variations:ios_chrome_ui_string_overrider_factory",
+ "//ios/chrome/browser/browser_state",
+ "//ios/chrome/browser/sync/glue",
"//ios/chrome/common",
- "//ios/chrome/common/app_group",
- "//ios/chrome/common/physical_web",
"//ios/net",
- "//ios/public/provider/chrome/browser",
- "//ios/public/provider/web",
"//ios/web",
"//ios/web:user_agent",
- "//ios/web/public/app",
"//net",
- "//net:extras",
- "//services/service_manager/public/cpp",
- "//skia",
- "//third_party/brotli",
- "//third_party/google_toolbox_for_mac",
- "//third_party/libwebp:libwebp_dec",
- "//ui/base",
- "//ui/gfx",
- "//ui/resources",
- "//ui/strings",
"//url",
-
- # TODO(crbug.com/459705): add support for resource packing and change the
- # dependency to be on the packed resources instead of the unpacked ones.
- "//ios/chrome/app/resources",
- "//ios/chrome/app/strings",
- "//ios/chrome/app/theme",
]
-
allow_circular_includes_from = [
- ":about_flags",
- "//ios/chrome/browser/signin",
+ "//ios/chrome/browser/sync/glue",
+ "//ios/chrome/browser/browser_state",
]
+ libs = [ "UIKit.framework" ]
+}
- libs = [
- "Accelerate.framework",
- "CoreGraphics.framework",
- "CoreLocation.framework",
- "Foundation.framework",
- "QuartzCore.framework",
- "UIKit.framework",
+source_set("browser_impl") {
+ sources = [
+ "application_context_impl.cc",
+ "application_context_impl.h",
+ "ios_chrome_main_parts.h",
+ "ios_chrome_main_parts.mm",
+ ]
+ deps = [
+ ":about_flags",
+ ":browser_no_public_deps",
+ "//base",
+ "//components/component_updater",
+ "//components/content_settings/core/browser",
+ "//components/content_settings/core/common",
+ "//components/flags_ui",
+ "//components/gcm_driver",
+ "//components/history/core/browser",
+ "//components/language_usage_metrics",
+ "//components/metrics:profiler_ios",
+ "//components/metrics_services_manager",
+ "//components/net_log",
+ "//components/network_time",
+ "//components/open_from_clipboard",
+ "//components/physical_web/data_source",
+ "//components/prefs",
+ "//components/rappor",
+ "//components/translate/core/browser",
+ "//components/update_client",
+ "//components/variations",
+ "//components/variations/service",
+ "//ios/chrome/browser/browser_state",
+ "//ios/chrome/browser/browser_state:browser_state_impl",
+ "//ios/chrome/browser/component_updater",
+ "//ios/chrome/browser/first_run",
+ "//ios/chrome/browser/history",
+ "//ios/chrome/browser/metrics",
+ "//ios/chrome/browser/net",
+ "//ios/chrome/browser/open_from_clipboard",
+ "//ios/chrome/browser/physical_web",
+ "//ios/chrome/browser/prefs",
+ "//ios/chrome/browser/services/gcm",
+ "//ios/chrome/browser/translate",
+ "//ios/chrome/browser/update_client",
+ "//ios/chrome/browser/web_resource",
+ "//ios/chrome/common",
+ "//ios/public/provider/chrome/browser",
+ "//ios/web",
+ "//ios/web/public/app",
+ "//net",
+ "//ui/base",
]
if (enable_rlz) {
- sources += [
- "rlz/rlz_tracker_delegate_impl.cc",
- "rlz/rlz_tracker_delegate_impl.h",
- ]
-
- deps += [
- "//components/rlz",
- "//rlz:rlz_lib",
- ]
+ deps += [ "//ios/chrome/browser/rlz" ]
}
}
@@ -738,14 +248,13 @@ source_set("browser") {
# other files (which would increase the compilation time when changing
# the value).
source_set("about_flags") {
- visibility = [ ":browser" ]
-
sources = [
"about_flags.h",
"about_flags.mm",
]
deps = [
+ ":browser_no_public_deps",
"//base",
"//components/autofill/core/common",
"//components/dom_distiller/core",
@@ -784,59 +293,41 @@ js_compile_unchecked("injected_js") {
]
}
+# TODO(crbug.com/658242): this target is there to avoid breaking downstream
+# when this CL rolls.
source_set("test_support") {
testonly = true
- sources = [
- "browser_state/test_chrome_browser_state.h",
- "browser_state/test_chrome_browser_state.mm",
- "browser_state/test_chrome_browser_state_isolated_context.h",
- "browser_state/test_chrome_browser_state_isolated_context.mm",
- "browser_state/test_chrome_browser_state_manager.cc",
- "browser_state/test_chrome_browser_state_manager.h",
- "geolocation/test_location_manager.h",
- "geolocation/test_location_manager.mm",
- "net/mock_image_fetcher.h",
- "net/mock_image_fetcher.mm",
- "sync/fake_sync_service_factory.cc",
- "sync/fake_sync_service_factory.h",
- "sync/ios_chrome_profile_sync_test_util.cc",
- "sync/ios_chrome_profile_sync_test_util.h",
- "sync/sync_setup_service_mock.cc",
- "sync/sync_setup_service_mock.h",
+ public_deps = [
+ "//ios/chrome/browser/browser_state:test_support",
+ "//ios/chrome/browser/geolocation:test_support",
+ "//ios/chrome/browser/net:test_support",
+ "//ios/chrome/browser/sync:test_support",
]
+}
+source_set("unit_tests") {
+ testonly = true
+ sources = [
+ "chrome_url_util_unittest.mm",
+ "crash_loop_detection_util_unittest.mm",
+ "install_time_util_unittest.mm",
+ "installation_notifier_unittest.mm",
+ "ios_chrome_io_thread_unittest.mm",
+ "notification_promo_unittest.cc",
+ ]
deps = [
":browser",
"//base",
- "//components/bookmarks/browser",
- "//components/browser_sync",
- "//components/browser_sync:test_support",
- "//components/history/core/browser",
- "//components/history/ios/browser",
- "//components/keyed_service/core",
- "//components/keyed_service/ios",
- "//components/pref_registry:test_support",
- "//components/signin/core/browser",
- "//components/signin/core/browser:test_support",
- "//components/signin/ios/browser",
- "//components/signin/ios/browser:test_support",
- "//components/sync",
- "//components/sync:test_support_driver",
- "//components/syncable_prefs",
- "//components/syncable_prefs:test_support",
- "//components/user_prefs",
- "//components/webdata_services",
- "//ios/chrome/browser",
- "//ios/chrome/browser/signin",
- "//ios/chrome/common",
- "//ios/chrome/test",
- "//ios/public/provider/chrome/browser",
- "//ios/public/provider/chrome/browser:test_support",
- "//ios/web",
+ "//base/test:test_support",
+ "//components/prefs",
+ "//components/prefs:test_support",
+ "//components/proxy_config",
+ "//components/ssl_config",
+ "//components/variations",
+ "//ios/web:test_support",
+ "//net",
"//net:test_support",
- "//testing/gmock",
"//testing/gtest",
- "//ui/base",
"//url",
]
}
« no previous file with comments | « ios/chrome/app/application_delegate/BUILD.gn ('k') | ios/chrome/browser/autocomplete/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698