ios/chrome/browser/rlz/BUILD.gn - Issue 2443373002: Split //ios/chrome/browser in multiple targets.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/rlz/BUILD.gn

Issue 2443373002: Split //ios/chrome/browser in multiple targets. (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("rlz") {
	rohitrao (ping after 24h) 2016/10/25 19:48:53 Should this whole target be behind enable_rlz? Should this whole target be behind enable_rlz? sdefresne 2016/10/25 21:10:23 No, in general we avoid putting targets behind if( Show quoted text On 2016/10/25 19:48:53, rohitrao wrote: > Should this whole target be behind enable_rlz? No, in general we avoid putting targets behind if(). This allow for example to write unit tests for it, even if the support is disabled in the app. And if no target depend on it, the file will not be loaded and the target won't be defined.
	6 sources = [

	7 "rlz_tracker_delegate_impl.cc",

	8 "rlz_tracker_delegate_impl.h",

	9 ]

	10 deps = [

	11 "//base",

	12 "//components/omnibox/browser",

	13 "//components/rlz",

	14 "//components/search_engines",

	15 "//ios/chrome/browser:browser_no_public_deps",

	16 "//ios/chrome/browser/browser_state",

	17 "//ios/chrome/browser/google",

	18 "//ios/chrome/browser/search_engines",

	19 "//ios/web",

	20 ]

	21 }

OLD	NEW