Chromium Code Reviews Chromium Code Reviews
Issue 2443373002:
Split //ios/chrome/browser in multiple targets. (Closed)
| OLD | NEW |
|---|---|
| (Empty) | |
| 1 # Copyright 2016 The Chromium Authors. All rights reserved. | |
| 2 # Use of this source code is governed by a BSD-style license that can be | |
| 3 # found in the LICENSE file. | |
| 4 | |
| 5 source_set("passwords") { | |
| 6 sources = [ | |
| 7 "credential_manager.h", | |
| 8 "credential_manager.mm", | |
| 9 "ios_chrome_password_manager_client.h", | |
| 10 "ios_chrome_password_manager_client.mm", | |
| 11 "ios_chrome_password_manager_driver.h", | |
| 12 "ios_chrome_password_manager_driver.mm", | |
| 13 "ios_chrome_password_manager_infobar_delegate.h", | |
| 14 "ios_chrome_password_manager_infobar_delegate.mm", | |
| 15 "ios_chrome_password_manager_setting_migrator_service_factory.cc", | |
| 16 "ios_chrome_password_manager_setting_migrator_service_factory.h", | |
| 17 "ios_chrome_password_store_factory.cc", | |
| 18 "ios_chrome_password_store_factory.h", | |
| 19 "ios_chrome_save_password_infobar_delegate.h", | |
| 20 "ios_chrome_save_password_infobar_delegate.mm", | |
| 21 "ios_chrome_update_password_infobar_delegate.h", | |
| 22 "ios_chrome_update_password_infobar_delegate.mm", | |
| 23 "js_credential_manager.h", | |
| 24 "js_credential_manager.mm", | |
| 25 "js_password_manager.h", | |
| 26 "js_password_manager.mm", | |
| 27 "password_controller.h", | |
| 28 "password_controller.mm", | |
| 29 "password_generation_agent.h", | |
| 30 "password_generation_agent.mm", | |
| 31 "password_generation_edit_view.h", | |
| 32 "password_generation_edit_view.mm", | |
| 33 "password_generation_offer_view.h", | |
| 34 "password_generation_offer_view.mm", | |
| 35 "password_generation_prompt_delegate.h", | |
| 36 "passwords_ui_delegate.h", | |
| 37 "update_password_infobar_controller.h", | |
| 38 "update_password_infobar_controller.mm", | |
| 39 ] | |
| 40 deps = [ | |
| 41 "//base", | |
| 42 "//base:i18n", | |
| 43 "//components/autofill/core/browser", | |
| 44 "//components/autofill/core/common", | |
| 45 "//components/autofill/ios/browser", | |
| 46 "//components/browser_sync", | |
| 47 "//components/infobars/core", | |
| 48 "//components/keyed_service/core", | |
| 49 "//components/keyed_service/ios", | |
| 50 "//components/password_manager/core/browser", | |
| 51 "//components/password_manager/core/common", | |
| 52 "//components/password_manager/sync/browser", | |
| 53 "//components/prefs", | |
| 54 "//components/signin/core/browser", | |
| 55 "//components/strings", | |
| 56 "//components/sync", | |
| 57 "//google_apis", | |
| 58 "//ios/chrome/app/strings", | |
| 59 "//ios/chrome/app/theme", | |
| 60 "//ios/chrome/browser:browser_no_public_deps", | |
| 61 "//ios/chrome/browser/autofill", | |
| 62 "//ios/chrome/browser/browser_state", | |
| 63 "//ios/chrome/browser/infobars", | |
| 64 "//ios/chrome/browser/signin", | |
| 65 "//ios/chrome/browser/sync/glue", | |
| 66 "//ios/chrome/browser/ui", | |
| 67 "//ios/chrome/browser/ui/commands", | |
| 68 "//ios/chrome/browser/ui/elements", | |
| 69 "//ios/public/provider/chrome/browser", | |
| 70 "//ios/web", | |
| 71 "//ui/base", | |
| 72 "//url", | |
| 73 ] | |
| 74 public_deps = [ | |
| 75 ":passwords_generation_utils", | |
| 76 ] | |
| 77 | |
| 78 allow_circular_includes_from = [ ":passwords_generation_utils" ] | |
| 79 } | |
| 80 | |
| 81 source_set("passwords_generation_utils") { | |
|
rohitrao (ping after 24h)
2016/10/25 19:48:53
Why was this split out?
sdefresne
2016/10/25 21:10:23
To break a cycle with //ios/chrome/browser/autofil
| |
| 82 sources = [ | |
| 83 "password_generation_utils.h", | |
| 84 "password_generation_utils.mm", | |
| 85 ] | |
| 86 deps = [ | |
| 87 "//base:i18n", | |
| 88 "//ios/chrome/browser/ui", | |
| 89 ] | |
| 90 libs = [ "CoreGraphics.framework" ] | |
| 91 } | |
| 92 | |
| 93 source_set("unit_tests") { | |
| 94 testonly = true | |
| 95 sources = [ | |
| 96 "credential_manager_js_unittest.mm", | |
| 97 "credential_manager_unittest.mm", | |
| 98 "password_controller_js_unittest.mm", | |
| 99 "password_controller_off_the_record_unittest.mm", | |
| 100 "password_controller_unittest.mm", | |
| 101 "password_generation_agent_unittest.mm", | |
| 102 ] | |
| 103 deps = [ | |
| 104 ":passwords", | |
| 105 "//base", | |
| 106 "//base/test:test_support", | |
| 107 "//components/autofill/core/common", | |
| 108 "//components/autofill/ios/browser", | |
| 109 "//components/password_manager/core/browser", | |
| 110 "//components/password_manager/core/browser:test_support", | |
| 111 "//components/password_manager/core/common", | |
| 112 "//components/prefs", | |
| 113 "//components/prefs:test_support", | |
| 114 "//google_apis", | |
| 115 "//ios/chrome/browser/autofill", | |
| 116 "//ios/chrome/browser/browser_state:test_support", | |
| 117 "//ios/chrome/browser/ui/commands", | |
| 118 "//ios/testing:ocmock_support", | |
| 119 "//ios/web", | |
| 120 "//ios/web:test_support", | |
| 121 "//testing/gtest", | |
| 122 "//third_party/ocmock", | |
| 123 "//url", | |
| 124 ] | |
| 125 } | |
| OLD | NEW |
