ios/chrome/browser/google/BUILD.gn - Issue 2443373002: Split //ios/chrome/browser in multiple targets.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/google/BUILD.gn

Issue 2443373002: Split //ios/chrome/browser in multiple targets. (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("google") {

	6 sources = [

	7 "google_brand.h",

	8 "google_brand.mm",

	9 "google_url_tracker_client_impl.cc",

	10 "google_url_tracker_client_impl.h",

	11 "google_url_tracker_factory.cc",

	12 "google_url_tracker_factory.h",

	13 ]

	14 deps = [

	15 "//base",

	16 "//components/google/core/browser",

	17 "//components/keyed_service/ios",

	18 "//components/prefs",

	19 "//ios/chrome/browser/browser_state",

	20 "//ios/public/provider/chrome/browser",

	21 ]

	22 }

	23

	24 source_set("google_logo") {
	rohitrao (ping after 24h) 2016/10/25 19:48:53 I'd name this logo_service. I'd name this logo_service. sdefresne 2016/10/25 21:10:23 Done. Show quoted text On 2016/10/25 19:48:53, rohitrao wrote: > I'd name this logo_service. Done.
	25 sources = [

	26 "google_logo_service.h",

	27 "google_logo_service.mm",

	28 "google_logo_service_factory.h",

	29 "google_logo_service_factory.mm",

	30 ]

	31 deps = [

	32 "//base",

	33 "//components/keyed_service/core",

	34 "//components/keyed_service/ios",

	35 "//components/search_engines",

	36 "//components/search_provider_logos",

	37 "//ios/chrome/browser/browser_state",

	38 "//ios/chrome/browser/search_engines",

	39 "//ios/web",

	40 "//net",

	41 "//ui/gfx",

	42 ]

	43 }

OLD	NEW