content/public/android/javatests/src/org/chromium/content/browser/webcontents/AccessibilitySnapshotTest.java - Issue 2443353003: The Android ViewStructure font size should be in physical pixels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/webcontents/AccessibilitySnapshotTest.java

Issue 2443353003: The Android ViewStructure font size should be in physical pixels (Closed)

Patch Set: Reword Android pixels to physical pixels Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/javatests/src/org/chromium/content/browser/webcontents/AccessibilitySnapshotTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/webcontents/AccessibilitySnapshotTest.java b/content/public/android/javatests/src/org/chromium/content/browser/webcontents/AccessibilitySnapshotTest.java

index 271026b88febd640e4884391697ae569e08b1c6e..cc9f23879d6e8fd5a9f1a2e9b4f742d3644b468b 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/webcontents/AccessibilitySnapshotTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/webcontents/AccessibilitySnapshotTest.java

@@ -91,7 +91,7 @@ public class AccessibilitySnapshotTest extends ContentShellTestBase {

@SmallTest

public void testRequestAccessibilitySnapshotFontSize() throws Throwable {

final String data = "<html><head><style> "

- + " body { font-size:11px; }"

+ + " p { font-size:16px; transform: scale(2); }"

+ " </style></head><body><p>foo</p></body></html>";

AccessibilitySnapshotNode root = receiveAccessibilitySnapshot(data, null);

assertEquals(1, root.children.size());

@@ -100,7 +100,8 @@ public class AccessibilitySnapshotTest extends ContentShellTestBase {

assertTrue(child.hasStyle);

assertEquals("foo", child.text);

- assertEquals(11.0, child.textSize, 0.01);

+ // The font size should take the scale into account.

+ assertEquals(32.0, child.textSize, 1.0);

}

@SmallTest

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | no next file » | no next file with comments »