The Android ViewStructure font size should be in physical pixels

content/browser/web_contents/web_contents_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_android.h"
 
 #include <stdint.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
@@ skipping 88 matching lines @@
   // they are not. Use a negative size information to indicate the existence
   // of style information.
   float size = -1.0;
   int color = 0;
   int bgcolor = 0;
   int text_style = 0;
 
   if (node->HasFloatAttribute(ui::AX_ATTR_FONT_SIZE)) {
     color = node->GetIntAttribute(ui::AX_ATTR_COLOR);
     bgcolor = node->GetIntAttribute(ui::AX_ATTR_BACKGROUND_COLOR);
+    text_style = node->GetIntAttribute(ui::AX_ATTR_TEXT_STYLE);
+
+    // The font size is just the computed style for that element; apply
+    // transformations to get the actual pixel size.
     size =  node->GetFloatAttribute(ui::AX_ATTR_FONT_SIZE);

[boliu, 2016/10/25 17:20:19]

nit: can you pass this directly into RectF constructor instead of assigning to
|size|? seeing size being updated twice looks odd..

[dmazzoni, 2016/10/25 17:31:16]

Done.

-    text_style = node->GetIntAttribute(ui::AX_ATTR_TEXT_STYLE);
+    gfx::RectF text_size_rect(0, 0, 1, size);
+    gfx::Rect scaled_text_size_rect = node->RelativeToAbsoluteBounds(
+        text_size_rect, false);
+    size = scaled_text_size_rect.height();
   }
 
   const gfx::Rect& absolute_rect = node->GetPageBoundsRect();
   gfx::Rect parent_relative_rect = absolute_rect;
   bool is_root = node->GetParent() == nullptr;
   if (!is_root) {
     parent_relative_rect.Offset(-parent_rect.OffsetFromOrigin());
   }
   ScopedJavaLocalRef<jobject> j_node =
       Java_WebContentsImpl_createAccessibilitySnapshotNode(
@@ skipping 606 matching lines @@
     Java_WebContentsImpl_addToBitmapList(env, jbitmaps, jbitmap);
   }
   for (const gfx::Size& size : sizes) {
     Java_WebContentsImpl_createSizeAndAddToList(env, jsizes, size.width(),
                                                 size.height());
   }
   Java_WebContentsImpl_onDownloadImageFinished(
       env, *obj, *callback, id, http_status_code, jurl, jbitmaps, jsizes);
 }
 }  // namespace content