Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2443323002: Remove pre-MD incognito frame avatar. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
Peter Kasting, oshima
CC:
chromium-reviews, kalyank, sadrul, tfarina, oshima+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pre-MD incognito frame avatar. BUG=648281 Committed: https://crrev.com/b228d6f45494c604297babc9b5bbe38e5f728ed8 Cr-Commit-Position: refs/heads/master@{#427348}

Patch Set 1 #

Patch Set 2 : remove more includes #

Total comments: 2

Patch Set 3 : adjust wrapping #

Messages

Total messages: 17 (10 generated)
Evan Stade
4 years, 1 month ago (2016-10-24 19:24:19 UTC) #5
Peter Kasting
LGTM https://codereview.chromium.org/2443323002/diff/20001/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc File chrome/browser/ui/views/frame/browser_non_client_frame_view.cc (right): https://codereview.chromium.org/2443323002/diff/20001/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc#newcode172 chrome/browser/ui/views/frame/browser_non_client_frame_view.cc:172: // the "correct" state as an override. Nit: ...
4 years, 1 month ago (2016-10-24 23:36:00 UTC) #9
oshima
lgtm
4 years, 1 month ago (2016-10-25 00:38:34 UTC) #10
Evan Stade
https://codereview.chromium.org/2443323002/diff/20001/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc File chrome/browser/ui/views/frame/browser_non_client_frame_view.cc (right): https://codereview.chromium.org/2443323002/diff/20001/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc#newcode172 chrome/browser/ui/views/frame/browser_non_client_frame_view.cc:172: // the "correct" state as an override. On 2016/10/24 ...
4 years, 1 month ago (2016-10-25 14:08:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443323002/40001
4 years, 1 month ago (2016-10-25 14:08:34 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-25 14:46:56 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 14:49:06 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b228d6f45494c604297babc9b5bbe38e5f728ed8
Cr-Commit-Position: refs/heads/master@{#427348}

Powered by Google App Engine
This is Rietveld 408576698