Add more tests to arc_navigation_throttle.cc

components/arc/intent_helper/arc_intent_helper_bridge.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_
 #define COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 70 matching lines @@
   static mojom::IntentHelperInstance* GetIntentHelperInstanceWithErrorCode(
       const std::string& method_name_for_logging,
       uint32_t min_instance_version,
       GetResult* out_error_code);
 
   // Does the same as above without asking for the error code.
   static mojom::IntentHelperInstance* GetIntentHelperInstance(
       const std::string& method_name_for_logging,
       uint32_t min_instance_version);
 
+  static constexpr char kArcIntentHelperPackageName[] =

[Luis Héctor Chávez, 2016/10/24 20:24:34]

would this cause an ODR violation?

[Yusuke Sato, 2016/10/24 22:27:16]

does it? I thought if the variable is odr-used, a definition in .cc was required
(but I may be wrong.)

anyway, I've changed it to const. No class in Chromium seems to have static
constexpr char[], and introducing it here seems like a bad idea. Done.

+      "org.chromium.arc.intent_helper";
+
  private:
   mojo::Binding<mojom::IntentHelperHost> binding_;
   scoped_refptr<ActivityIconLoader> icon_loader_;
   scoped_refptr<LocalActivityResolver> activity_resolver_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcIntentHelperBridge);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_