Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2443303002: Revert of Add the shortcut to toggle high contrast mode to the keyboard overlay (Closed)

Created:
4 years, 1 month ago by dmazzoni
Modified:
4 years, 1 month ago
Reviewers:
afakhry, xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add the shortcut to toggle high contrast mode to the keyboard overlay (patchset #1 id:20001 of https://codereview.chromium.org/2379673002/ ) Reason for revert: http://crbug.com/653330 This shortcut conflicts with some web pages, and there's no consensus on the proper fix (let web pages override, or switch to another key). Original issue's description: > Add the shortcut to toggle high contrast mode to the keyboard overlay > > Screenshot https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LMUpQRG02OXRYU1k/view?usp=sharing > > BUG=644758 > TEST=open keyboard overlay, hit Ctrl+Alt, and look at the H key. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/23f688e8fe28d1b260cedba104bf0783331126d4 > Cr-Commit-Position: refs/heads/master@{#421587} TBR=xiyuan@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=644758 Committed: https://crrev.com/8bd3125aba3a1900c6038b9a4f7e802376820952 Cr-Commit-Position: refs/heads/master@{#427163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dmazzoni
Created Revert of Add the shortcut to toggle high contrast mode to the keyboard overlay
4 years, 1 month ago (2016-10-24 17:56:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443303002/1
4 years, 1 month ago (2016-10-24 17:57:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 21:50:03 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 21:56:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bd3125aba3a1900c6038b9a4f7e802376820952
Cr-Commit-Position: refs/heads/master@{#427163}

Powered by Google App Engine
This is Rietveld 408576698