Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: net/nqe/network_quality_estimator.cc

Issue 2443293002: Record main frame UMA without breaking down by the connection type. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.cc
diff --git a/net/nqe/network_quality_estimator.cc b/net/nqe/network_quality_estimator.cc
index 96a4518e4cacc83b3907340e639e92db06c2281c..fc6ed937aeb11eee266a16b302954de116f77aea 100644
--- a/net/nqe/network_quality_estimator.cc
+++ b/net/nqe/network_quality_estimator.cc
@@ -1188,6 +1188,7 @@ void NetworkQualityEstimator::RecordMetricsOnMainFrameRequest() const {
base::TimeDelta http_rtt;
if (GetHttpRTT(&http_rtt)) {
// Add the 50th percentile value.
+ UMA_HISTOGRAM_TIMES("NQE.MainFrame.RTT.Percentile50", http_rtt);
base::HistogramBase* rtt_percentile = GetHistogram(
"MainFrame.RTT.Percentile50.", current_network_id_.type, 10 * 1000);
rtt_percentile->Add(http_rtt.InMilliseconds());
@@ -1196,6 +1197,8 @@ void NetworkQualityEstimator::RecordMetricsOnMainFrameRequest() const {
base::TimeDelta transport_rtt;
if (GetTransportRTT(&transport_rtt)) {
// Add the 50th percentile value.
+ UMA_HISTOGRAM_TIMES("NQE.MainFrame.TransportRTT.Percentile50",
+ transport_rtt);
base::HistogramBase* transport_rtt_percentile =
GetHistogram("MainFrame.TransportRTT.Percentile50.",
current_network_id_.type, 10 * 1000);
@@ -1205,6 +1208,7 @@ void NetworkQualityEstimator::RecordMetricsOnMainFrameRequest() const {
int32_t kbps;
if (GetDownlinkThroughputKbps(&kbps)) {
// Add the 50th percentile value.
+ UMA_HISTOGRAM_COUNTS_1M("NQE.MainFrame.Kbps.Percentile50", kbps);
base::HistogramBase* throughput_percentile = GetHistogram(
"MainFrame.Kbps.Percentile50.", current_network_id_.type, 1000 * 1000);
throughput_percentile->Add(kbps);
@@ -1212,6 +1216,9 @@ void NetworkQualityEstimator::RecordMetricsOnMainFrameRequest() const {
const EffectiveConnectionType effective_connection_type =
GetEffectiveConnectionType();
+ UMA_HISTOGRAM_ENUMERATION("NQE.MainFrame.EffectiveConnectionType",
+ effective_connection_type,
+ EFFECTIVE_CONNECTION_TYPE_LAST);
base::HistogramBase* effective_connection_type_histogram =
base::Histogram::FactoryGet(
std::string("NQE.MainFrame.EffectiveConnectionType.") +
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698