Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2443293002: Record main frame UMA without breaking down by the connection type. (Closed)

Created:
4 years, 1 month ago by tbansal1
Modified:
4 years, 1 month ago
Reviewers:
bengr, RyanSturm
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record main frame UMA without breaking down by the connection type. BUG=659399 Committed: https://crrev.com/36c6fe324da898cf991f91b4ad23f084c759dbc5 Cr-Commit-Position: refs/heads/master@{#428105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M net/nqe/network_quality_estimator.cc View 4 chunks +7 lines, -0 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 7 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
tbansal1
ptal. thanks.
4 years, 1 month ago (2016-10-26 00:33:55 UTC) #7
RyanSturm
lgtm
4 years, 1 month ago (2016-10-26 01:03:03 UTC) #8
tbansal1
bengr: ptal. thanks.
4 years, 1 month ago (2016-10-26 01:04:39 UTC) #10
bengr
lgtm
4 years, 1 month ago (2016-10-27 18:12:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443293002/1
4 years, 1 month ago (2016-10-27 18:13:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 19:07:33 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 19:32:40 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36c6fe324da898cf991f91b4ad23f084c759dbc5
Cr-Commit-Position: refs/heads/master@{#428105}

Powered by Google App Engine
This is Rietveld 408576698